Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "πŸ—„οΈ aspect:data" label #3589

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

firatbezir
Copy link
Contributor

@firatbezir firatbezir commented Dec 26, 2023

Fixes

Fixes #3574 by @AetherUnbound

Description

This pr adds aspect:data label

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@firatbezir firatbezir requested a review from a team as a code owner December 26, 2023 10:27
@openverse-bot openverse-bot added 🟩 priority: low Low priority and doesn't need to be rushed 🌟 goal: addition Addition of new feature πŸ€– aspect: dx Concerns developers' experience with the codebase 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Dec 26, 2023
@obulat obulat requested review from obulat and removed request for fcoveram December 26, 2023 10:29
@obulat obulat added 🧱 stack: mgmt Related to repo management and automations and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Dec 26, 2023
automations/data/labels.yml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@firatbezir firatbezir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit is done.

@obulat obulat requested review from AetherUnbound and removed request for sarayourfriend December 26, 2023 11:58
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is scope to bikeshed the emoji but from a code change perspective, this is really good. Thanks for contributing @firatbezir!

@@ -122,6 +122,9 @@ groups:
- name: code
description: Concerns the software code in the repository
emoji: "πŸ’»"
- name: data
description: Concerns the data
emoji: "πŸ“š"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much bikeshedding but a stack of books reminds me of docs more than data. I was leaning more towards these options:

  • πŸ’Ύ πŸ’Ώ (digital data storage)
  • πŸ—ƒοΈ πŸ—„οΈ (physical data storage)
  • πŸ“ˆ πŸ“Š (data output)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dhruvkb😊. This is funny, at the first step, i was thinking using this => πŸ“Š, and then realized @AetherUnbound suggests the one I added. Hopefully, it functions as it is expected thanks to @obulat.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much bikeshedding but a stack of books reminds me of docs more than data. I was leaning more towards these options:

  • πŸ’Ύ πŸ’Ώ (digital data storage)
  • πŸ—ƒοΈ πŸ—„οΈ (physical data storage)
  • πŸ“ˆ πŸ“Š (data output)

Are you suggesting we should use 2 icons for data, @dhruvkb? Which, if you had to choose?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ambivalent! Though I do like the cabinets personally πŸ˜† I mostly chose the books because of our "catalog" 😁

Copy link
Member

@dhruvkb dhruvkb Dec 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was giving ~6 choices without any preference for any of them, although it definitely should be just one. If I had to choose, I'd probably go for the cabinets πŸ—„οΈ too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emoji updated to cabinets πŸ—„οΈ.

Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thought for wording!

automations/data/labels.yml Outdated Show resolved Hide resolved
Co-authored-by: Madison Swain-Bowden <[email protected]>
@firatbezir firatbezir closed this Dec 26, 2023
@firatbezir firatbezir reopened this Dec 26, 2023
automations/data/labels.yml Outdated Show resolved Hide resolved
@dhruvkb dhruvkb changed the title Add aspect:data label Add "πŸ—„οΈ aspect:data" label Dec 27, 2023
@dhruvkb dhruvkb merged commit 0f2e7f0 into WordPress:main Dec 27, 2023
40 checks passed
@firatbezir firatbezir deleted the add/aspect_data branch March 30, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ€– aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add an aspect: data label?
5 participants