-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "ποΈ aspect:data" label #3589
Conversation
Co-authored-by: Olga Bulat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is scope to bikeshed the emoji but from a code change perspective, this is really good. Thanks for contributing @firatbezir!
automations/data/labels.yml
Outdated
@@ -122,6 +122,9 @@ groups: | |||
- name: code | |||
description: Concerns the software code in the repository | |||
emoji: "π»" | |||
- name: data | |||
description: Concerns the data | |||
emoji: "π" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much bikeshedding but a stack of books reminds me of docs more than data. I was leaning more towards these options:
- πΎ πΏ (digital data storage)
- ποΈ ποΈ (physical data storage)
- π π (data output)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dhruvkbπ. This is funny, at the first step, i was thinking using this => π, and then realized @AetherUnbound suggests the one I added. Hopefully, it functions as it is expected thanks to @obulat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much bikeshedding but a stack of books reminds me of docs more than data. I was leaning more towards these options:
- πΎ πΏ (digital data storage)
- ποΈ ποΈ (physical data storage)
- π π (data output)
Are you suggesting we should use 2 icons for data, @dhruvkb? Which, if you had to choose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ambivalent! Though I do like the cabinets personally π I mostly chose the books because of our "catalog" π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was giving ~6 choices without any preference for any of them, although it definitely should be just one. If I had to choose, I'd probably go for the cabinets ποΈ too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emoji updated to cabinets ποΈ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thought for wording!
Co-authored-by: Madison Swain-Bowden <[email protected]>
Fixes
Fixes #3574 by @AetherUnbound
Description
This pr adds
aspect:data
labelTesting Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin