Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft migration to Nuxt 3 - not ready yet #3571

Closed
wants to merge 150 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
150 commits
Select commit Hold shift + click to select a range
030d0d9
Initial dependency changes
obulat Dec 13, 2023
2b1707f
Update prometheus module
obulat Dec 18, 2023
a63a02b
Temporarily remove template-overrides
obulat Dec 18, 2023
edc45be
Update eslint settings
obulat Dec 18, 2023
60625e2
Patch @nuxtjs/svg-sprite
obulat Oct 30, 2023
53607ee
Add .output to gitignore
obulat Dec 13, 2023
28f82ac
Import from vue instead of composition-api
obulat Dec 13, 2023
5226d39
Replace useI18n import and i18n components
obulat Dec 18, 2023
a1f70ff
Rename static to public
obulat Dec 18, 2023
06fba84
Fix paths in fonts.css
obulat Dec 18, 2023
017efce
Remove $listeners
obulat Dec 14, 2023
46225bf
Move key to template
obulat Dec 14, 2023
4121249
Use defineNuxtComponent for pages
obulat Dec 19, 2023
e1d8ccc
Replace useHead with useMeta
obulat Dec 14, 2023
b6fd9c4
Replace router.push with navigateTo, and import useRouter from imports
obulat Dec 14, 2023
d7d69ec
Update useRoute
obulat Dec 14, 2023
3da728a
Update useLocalePath
obulat Dec 19, 2023
9988ed0
Convert useLocalePath in search store
obulat Dec 14, 2023
b555c91
Update locale in ui store
obulat Dec 19, 2023
25d88f8
Replace userEvent default export
obulat Dec 19, 2023
5a472ca
Update type augmentation
obulat Dec 19, 2023
3df2baf
Update cookie handling in ui and feature flag stores
obulat Dec 14, 2023
ca663fa
useAsyncComponent
obulat Dec 14, 2023
ccee994
Temporarily replace SSR Ref for last updated provider stats
obulat Dec 14, 2023
c27d9bb
app.vue and layouts update
obulat Dec 14, 2023
935d382
Update plausible set up
obulat Dec 14, 2023
3043009
Use runtimeConfig for base api url and hard-code ua
obulat Dec 14, 2023
720b28f
Initial Sentry setup
obulat Dec 19, 2023
fb69b61
Delete test svg-transform
obulat Dec 19, 2023
08633b3
Add report service initializer and get api token from useNuxtApp
obulat Dec 19, 2023
cb2579d
Replace _id with [id] dynamic pages
obulat Dec 19, 2023
b5555bf
Remove composition-api imports from pages
obulat Dec 19, 2023
1d75574
Use definePageMeta in pages
obulat Dec 19, 2023
11622aa
Add firstParam utility
obulat Dec 19, 2023
131e2cf
fix ua-parse
obulat Dec 19, 2023
05d53ae
Update modals
obulat Dec 19, 2023
f2b5d25
Fix homepage searchbar focusing
obulat Dec 19, 2023
057cc8b
Refactor VLink
obulat Dec 19, 2023
0645233
search middleware
obulat Dec 19, 2023
c9326fb
single-result middleware
obulat Dec 19, 2023
a20c577
first param search-query-transform.ts
obulat Dec 19, 2023
d1d3a54
Fix collection middleware and pages
obulat Dec 19, 2023
393de58
Replace tc with t and remove toString
obulat Dec 19, 2023
d495862
Refactor report page
obulat Dec 19, 2023
1c7b848
Fix class not being set on outer el when inheritattrs is false
obulat Oct 30, 2023
2012a8b
Remove deprecated `hid` from meta
obulat Dec 19, 2023
93f058b
Fix deep style in the row audio layout
obulat Dec 19, 2023
fe8b3b1
handle route name as symbol
obulat Dec 19, 2023
f3c9fcc
Fix search page fetching and add error boundary
obulat Dec 19, 2023
4bda006
Fix i18n imports
obulat Dec 19, 2023
dab83b1
eslint ignore unresolved
obulat Dec 19, 2023
5660104
Remove .native modifier
obulat Dec 19, 2023
8c4f3f8
fetch state types
obulat Dec 19, 2023
d27d2a0
VSearchBar model value update
obulat Dec 20, 2023
e6301d2
Update i18n mock in tests
obulat Dec 20, 2023
42c7392
Test changes
obulat Dec 20, 2023
0353216
Add redirects
obulat Dec 21, 2023
45bbb90
Fix tc
obulat Dec 21, 2023
50c0854
Remove unused middleware
obulat Dec 21, 2023
f19df4c
Add server routes
obulat Dec 21, 2023
2b83b5f
Replace env with useRuntimeConfig
obulat Dec 21, 2023
0deec18
Global scope for useI18n
obulat Dec 21, 2023
6ffa0d9
Remove user-agent
obulat Dec 21, 2023
fc65cd8
Use env variables in nuxt.config
obulat Dec 21, 2023
bdf6b96
Update pnpm
obulat Dec 21, 2023
69ac368
Remove unused import in app.vue
obulat Dec 21, 2023
00c8a29
Add postinstall
obulat Dec 21, 2023
3db37d7
Related params
obulat Dec 21, 2023
007747d
firstParam in VMetadata
obulat Dec 21, 2023
05cec06
Update analytics types
obulat Dec 22, 2023
e2c21fc
Feature flag location query types
obulat Dec 22, 2023
62eea03
Cookies types
obulat Dec 22, 2023
c5b6fe5
Add fallback for env variables
obulat Dec 22, 2023
a3811a7
Add meta types
obulat Dec 22, 2023
9ed98de
sentry-config types
obulat Dec 22, 2023
42956cd
Get Playwright running amd64 host
sarayourfriend Dec 22, 2023
491dc09
Configure ESLint for vitest and apply autofixable changes
sarayourfriend Dec 22, 2023
d23ca05
Remove invalid async annotation on describe callbacks (eslint)
sarayourfriend Dec 22, 2023
65f1327
Use global scope on all i18n-t components
sarayourfriend Dec 22, 2023
5b36342
Try fixing postinstall
obulat Dec 22, 2023
287aac5
Try fixing postinstall
obulat Dec 22, 2023
e2cc862
Try fixing postinstall
obulat Dec 23, 2023
49bc4ba
Fix prettier errors
obulat Dec 23, 2023
501eafe
Fix tests
obulat Dec 23, 2023
2a2a32c
Fix cookie types
obulat Dec 23, 2023
40e9435
Remove storybook from docs build
obulat Dec 23, 2023
55e5d5e
Temporarily replace fallback locale arrays with "en"
obulat Dec 23, 2023
95f6f0e
Fix Skip-to-content warning
obulat Dec 24, 2023
d61873e
Update url to fix test
obulat Dec 24, 2023
c0a6d4f
Update default SEO meta
obulat Dec 28, 2023
431b7b7
Fix Search type popover
obulat Dec 28, 2023
7345c82
Make nuxt.config use env variables
obulat Dec 28, 2023
9d053cb
Remove button to remove warnings
obulat Dec 28, 2023
6510223
Add test setup for e2e tests
obulat Dec 28, 2023
fe7f950
Remove retries
obulat Dec 28, 2023
5871636
Lint VModalContent
obulat Dec 29, 2023
e140ecb
Close analytics banner in filters
obulat Dec 29, 2023
c0740ff
Close analytics banner in filters
obulat Dec 29, 2023
9f87163
Set maxDiffPixelRatio to 0.01 to allow 1px difference
obulat Dec 29, 2023
c99d165
Close analytics in global audio
obulat Dec 29, 2023
beaf1ba
Close analytics in header
obulat Dec 29, 2023
8b8b554
Fix ui cookie in tests
obulat Dec 29, 2023
b89cc8a
Fix search-types urls
obulat Dec 29, 2023
880efec
Update header test
obulat Dec 29, 2023
35a676d
Try fixing frontend Docker build
obulat Dec 29, 2023
2ef5617
Fix home gallery layout
obulat Dec 30, 2023
62818f4
Fix rtl locators
obulat Dec 30, 2023
0b89e65
Set store search type on search page transitions
obulat Dec 30, 2023
97c2e79
Stop counting sensitive switches as filters
obulat Dec 30, 2023
8e60f31
Correctly set API url in talkback proxy
obulat Dec 30, 2023
99df4a0
Add missing stats responses
obulat Dec 30, 2023
fc86c82
Update preparePageForTests
obulat Dec 30, 2023
4fd807b
Fix error pages
obulat Dec 30, 2023
261635a
Temporarily increase PW timeout
obulat Dec 30, 2023
15c5762
Skip global audio tests
obulat Dec 31, 2023
6b935d7
Fix expected URL having extra `/`
obulat Dec 31, 2023
a02ed49
Add error handler plugin to set up ui store for errors
obulat Dec 31, 2023
2861b0b
Fix Playwright tests
obulat Dec 31, 2023
db30204
Fix prepare-nuxt script in Docker build
obulat Dec 31, 2023
e2c7a1c
Handle errors in locales
obulat Dec 31, 2023
eeebe93
Add setup to error page
obulat Dec 31, 2023
046686e
Fix Modal client-server mismatch
obulat Jan 1, 2024
9bb8df1
Move not working unit tests
obulat Jan 4, 2024
7669473
Override Vue version
obulat Jan 4, 2024
d9dbb86
Update package.json
obulat Jan 4, 2024
a009efc
Remove prometheus.ts
obulat Jan 4, 2024
4de94da
Fix ui store cookie type warnings
obulat Jan 4, 2024
0f6571a
Fix feature-flag store cookie type warnings
obulat Jan 4, 2024
82ce6ef
Remove unused cookies util
obulat Jan 4, 2024
638dd57
Dockerfile
obulat Jan 4, 2024
d919cf3
Fix or skip unit tests
obulat Jan 4, 2024
eec7582
Get i18n from useNuxtApp for unit tests
obulat Jan 5, 2024
e28370d
Remove accidentally re-added $style
obulat Jan 5, 2024
b6eb60e
Fix filters input count in test
obulat Jan 5, 2024
4f49265
Add export to pluging
obulat Jan 5, 2024
62ab4a4
Get i18n from useNuxtApp for unit tests
obulat Jan 5, 2024
2a71a50
Remove trailing slash from search path
obulat Jan 5, 2024
f77756d
Add "a" as button form for skip-to-content
obulat Jan 5, 2024
dbd97e5
Fix SingleResultControls id
obulat Jan 5, 2024
32e506c
Get i18n from useNuxtApp
obulat Jan 5, 2024
80d9d93
Fix composable unit tests
obulat Jan 5, 2024
51e3e01
Remove incorrect mock
obulat Jan 5, 2024
93e0bc8
Fix homepage vr
obulat Jan 5, 2024
0252309
Skip test
obulat Jan 5, 2024
1cf2359
Rename homepage test
obulat Jan 5, 2024
58fcfcc
Test fixes
obulat Jan 5, 2024
f86f590
Fix content report form v-model
obulat Jan 5, 2024
338f7cc
Fix EXTERNAL_LINK_CLICK condition
obulat Jan 5, 2024
415888e
Fix report tests
obulat Jan 5, 2024
cbe4eb1
Update lock file
obulat Jan 5, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
11 changes: 0 additions & 11 deletions .github/actions/build-docs/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,8 @@ runs:
# Pass -W to fail CI if warnings exist
just documentation/build -W

- name: Install translations
shell: bash
run: |
just frontend/run i18n

- name: Build Storybook
shell: bash
run: |
just frontend/run storybook:build-for-docs

# Storybook will be available at `/storybook`
- name: Merge all docs
shell: bash
run: |
mv documentation/_build /tmp/docs
mv frontend/storybook-static /tmp/docs/storybook
3 changes: 2 additions & 1 deletion .github/workflows/ci_cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ jobs:
if: matrix.image == 'frontend'
run: |
just frontend/run i18n
just frontend/run prepare-nuxt

- name: Setup Docker Buildx
uses: docker/setup-buildx-action@v3
Expand Down Expand Up @@ -631,7 +632,7 @@ jobs:
needs.get-changes.outputs.frontend == 'true' ||
needs.get-changes.outputs.ci_cd == 'true'
runs-on: ubuntu-latest
timeout-minutes: 15
timeout-minutes: 25
needs:
- get-changes
- lint
Expand Down
2 changes: 2 additions & 0 deletions frontend/.env.template
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#API_URL=http://127.17.0.1:8000/
#API_CLIENT_ID=""
#API_CLIENT_SECRET=""
NUXT_PUBLIC_SAVED_SEARCH_COUNT=4
NUXT_PUBLIC_PROVIDER_UPDATE_FREQUENCY=3600000
1 change: 1 addition & 0 deletions frontend/.gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Nuxt
.nuxt
.output

# Storybook
.nuxt-storybook
Expand Down
2 changes: 1 addition & 1 deletion frontend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ WORKDIR /home/node/

# Copy monorepo mocking files into `/home/node`, which pretends to be the monorepo root.
# Note: these files must be manually un-ignored in the root .dockerignore
COPY --from=repo_root --chown=node:node .npmrc .pnpmfile.cjs pnpm-lock.yaml tsconfig.base.json ./
COPY --from=repo_root --chown=node:node .npmrc .pnpmfile.cjs pnpm-lock.yaml ./
RUN echo '{"packages":["frontend/"]}' > pnpm-workspace.yaml

# Copy the `frontend/` directory into `/home/node/frontend`, as a package in the monorepo.
Expand Down
7 changes: 7 additions & 0 deletions frontend/Dockerfile.playwright
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,14 @@ FROM mcr.microsoft.com/playwright:v${PLAYWRIGHT_VERSION}-jammy

ARG PACKAGE_MANAGER

WORKDIR /frontend

COPY package.json .

# Requires `packageManager` field to be present in `frontend/package.json`.
RUN npm install -g $PACKAGE_MANAGER

# DO NOT actually run `pnpm install` here. Doing so requires us to copy the the source into the container.
# However, that's a waste of time because we mount the source in the compose file anyway.
# Instead, we run `pnpm install` in the entrypoint script defined in the compose file.
# ENTRYPOINT ["pnpm", "install", "&&"]
11 changes: 7 additions & 4 deletions frontend/docker-compose.playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,15 @@ services:
- PACKAGE_MANAGER=${PACKAGE_MANAGER}
- PLAYWRIGHT_VERSION=${PLAYWRIGHT_VERSION}
volumes:
- ../node_modules:/node_modules
- .:/frontend
- ${PWD}/../tsconfig.base.json:/tsconfig.base.json
- ../node_modules:/node_modules:rw,Z
- .:/frontend:rw,Z
user: ${USER_ID}
working_dir: /frontend
command: pnpm ${TEST_COMMAND} ${PLAYWRIGHT_ARGS:-}
entrypoint: >
/bin/sh -c '
pnpm install;
pnpm ${TEST_COMMAND} ${PLAYWRIGHT_ARGS:-};
'
environment:
# This makes the webserver that Playwright runs show the build
- DEBUG=pw:webserver
Expand Down
Loading
Loading