-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codeowners pre-commit check #3570
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4ba2b67
updating project's .pre-commit-config.yaml file to include a hook tha…
gmottajr 7331fd6
cleaning commit
gmottajr b27a94d
Merge remote-tracking branch 'upstream/main' into fix/posix-path-sepa…
gmottajr 54c6e2e
Changes requested during code review: We should add this to the exist…
gmottajr 32ce97e
Changes requested during code review: we don't need to use a shell s…
gmottajr 66335a6
Fixing CODEOWNERS validator hook failing. The error message indicated…
gmottajr 6b63fdd
Merge branch 'main' into fix/posix-path-separators
gmottajr 6033feb
Always run CODEOWNERS check if any files changed
sarayourfriend 2567f79
Merge branch 'WordPress:main' into fix/posix-path-separators
gmottajr b6b2fbc
Merge branch 'main' into fix/posix-path-separators
gmottajr 2c9de4d
Merge branch 'fix/posix-path-separators' of https://github.com/gmotta…
gmottajr ca3059c
Third round of the code review asked to avoid using this '*' all patt…
gmottajr 3db8229
Third round of the code review asked to avoid using this '*' all patt…
gmottajr 4b6117c
Merge branch 'main' into fix/posix-path-separators
gmottajr b690f67
Sort and add missing entries to CODEOWNERS
krysal fd20641
Merge branch 'main' into fix/posix-path-separators
krysal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,49 @@ | ||
| catalog/ @WordPress/openverse-catalog | ||
| archive/ @WordPress/openverse-catalog | ||
| # Specific assignments for the 'openverse-catalog' group | ||
| catalog/ @WordPress/openverse-catalog | ||
| archive/ @WordPress/openverse-catalog | ||
| dag-sync.sh @WordPress/openverse-catalog | ||
|
|
||
| api/ @WordPress/openverse-api | ||
| ingestion_server/ @WordPress/openverse-api | ||
| nginx/ @WordPress/openverse-api | ||
| postgres/ @WordPress/openverse-api | ||
| sample_data/ @WordPress/openverse-api | ||
| .flake8 @WordPress/openverse-api | ||
| .isort.cfg @WordPress/openverse-api | ||
| docker-compose.yml @WordPress/openverse-api | ||
| load_sample_data.sh @WordPress/openverse-api | ||
| pyproject.toml @WordPress/openverse-api | ||
|
|
||
| frontend/ @WordPress/openverse-frontend | ||
| packages/ @WordPress/openverse-frontend | ||
| .eslintignore @WordPress/openverse-frontend | ||
| .eslintrc.js @WordPress/openverse-frontend | ||
| .npmrc @WordPress/openverse-frontend | ||
| .pnpmfile.cjs @WordPress/openverse-frontend | ||
| .prettierignore @WordPress/openverse-frontend | ||
| package.json @WordPress/openverse-frontend | ||
| pnpm-lock.yaml @WordPress/openverse-frontend | ||
| pnpm-workspace.yaml @WordPress/openverse-frontend | ||
| prettier.config.js @WordPress/openverse-frontend | ||
| .prettierignore @WordPress/openverse-frontend | ||
| setup_plausible.sh @WordPress/openverse-frontend | ||
| tsconfig.base.json @WordPress/openverse-frontend | ||
|
|
||
| # Specific assignments for the 'openverse-maintainers' group | ||
| .codespell/ @WordPress/openverse-maintainers | ||
| .devcontainer/ @WordPress/openverse-maintainers | ||
| .github/ @WordPress/openverse-maintainers | ||
| automations/ @WordPress/openverse-maintainers | ||
| brand/ @WordPress/openverse-maintainers | ||
| dead_links/ @WordPress/openverse-maintainers | ||
| docker/ @WordPress/openverse-maintainers | ||
| documentation/ @WordPress/openverse-maintainers | ||
| readme_assets/ @WordPress/openverse-maintainers | ||
| templates/ @WordPress/openverse-maintainers | ||
| utilities/ @WordPress/openverse-maintainers | ||
| .dockerignore @WordPress/openverse-maintainers | ||
| .editorconfig @WordPress/openverse-maintainers | ||
| .git-blame-ignore-revs @WordPress/openverse-maintainers | ||
| .gitattributes @WordPress/openverse-maintainers | ||
| .gitignore @WordPress/openverse-maintainers | ||
| .github/ @WordPress/openverse-maintainers | ||
| .devcontainer/ @WordPress/openverse-maintainers | ||
| .pre-commit-config.yaml @WordPress/openverse-maintainers | ||
| CODE_OF_CONDUCT.md @WordPress/openverse-maintainers | ||
| CONTRIBUTING.md @WordPress/openverse-maintainers | ||
| justfile @WordPress/openverse-maintainers | ||
| LICENSE @WordPress/openverse-maintainers | ||
| README.md @WordPress/openverse-maintainers | ||
| docker-compose.yml @WordPress/openverse-maintainers | ||
| env.template @WordPress/openverse-maintainers | ||
| justfile @WordPress/openverse-maintainers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to include the checks for
notownedandavoid-shadowingonce they pass the experimental phase. Also, the description of the latter suggest than the*pattern may work as we want if it's specified before the more specific line but I haven't confirmed it 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
notownedcheck requires the branch to not have any uncommited changes, and so cannot run in our normalpre-commitstage. It's flaky to run it inpre-pushas well because it will still complain if there are uncommitted changes (like you have something you would have otherwise stashed).It's a good check but not currently easily usable. We'd need to add a separate step for it altogether, probably just in CI. I couldn't find an easy way to do that in pre-commit other than adding it with the
manualstage and then adding it to the CI lint job.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for enumerating the quirks of the
notownedcheck. I assumed there would be some complications, but nothing so disrupting 🤯 Anyway, my comment here was just a desire (though at first, I thought it was the whole reason to add it to pre-commit); I wasn't requesting changes for this to be clear.