Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize API HTTP alarms and remove thumbnails alarms runbooks #3523

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

krysal
Copy link
Member

@krysal krysal commented Dec 14, 2023

Fixes

Closes #2500 by @sarayourfriend
Closes #2502 by @sarayourfriend
Closes #2503 by @sarayourfriend

Description

This PR marks the 2xx & 5xx count over time alarms of the API as stabilized in runbooks. Since they've been running for a while, the 5xx alarm has confirmed several incidents, and while we have not had a sudden increase in requests but we still believe the alarm for 2xx responses could be useful in the future. Also, given we aren't using anymore a separated service for thumbnails it get rids of all the alarms related to that service as well.

Testing Instructions

Just check the updates docs are correct, reviewing from the link on the comment below or from the code 📖

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • [N/A] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 🟧 priority: high Stalls work on the project or its dependents 📄 aspect: text Concerns the textual material in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: documentation Related to Sphinx documentation labels Dec 14, 2023
@krysal krysal requested a review from a team as a code owner December 14, 2023 01:53
@openverse-bot openverse-bot added the 💻 aspect: code Concerns the software code in the repository label Dec 14, 2023
@krysal krysal requested review from dhruvkb and removed request for fcoveram December 14, 2023 01:54
@krysal
Copy link
Member Author

krysal commented Dec 14, 2023

@dhruvkb For some reason, the @openverse-bot added the label aspect: code in this PR even when it doesn't touch any code and I had already created it with an aspect label, it wasn't necessary to add that 🤔

Screenshot 2023-12-13 at 21-55-12 Stabilize API HTTP alarms and remove thumbnails alarms runbooks by krysal · Pull Request #3523 · WordPress_openverse

@krysal krysal removed the 💻 aspect: code Concerns the software code in the repository label Dec 14, 2023
Copy link

Full-stack documentation: https://docs.openverse.org/_preview/3523

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Changed files 🔄:

Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for removing alarms! I have a few comments/notes for the stabilized alarms.

@krysal krysal force-pushed the update/alarms-runbooks branch from 2d2be27 to 32fea18 Compare December 15, 2023 03:34
@krysal krysal force-pushed the update/alarms-runbooks branch from 32fea18 to 8e3d262 Compare December 15, 2023 03:36
@krysal krysal requested a review from AetherUnbound December 15, 2023 03:36
@AetherUnbound
Copy link
Collaborator

Oh nooo, it looks like our GitHub username parser is interpreting these as usernames 😅
image

I think this runbook directory might have a few such cases, since viewing Log Insights is pretty common. Would you mind adding a way to exclude that particular folder from the username parsing script?

@krysal krysal mentioned this pull request Dec 15, 2023
1 task
@sarayourfriend
Copy link
Collaborator

sarayourfriend commented Dec 18, 2023

@AetherUnbound Can't that be a separate issue? I don't think it needs to block this information getting into main, at least?

Here's an issue for it: #3542 (update:) ... and here's a PR 🙂 #3543

Copy link
Collaborator

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@openverse-bot
Copy link
Collaborator

Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR:

@AetherUnbound
@dhruvkb
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was ready for review 2 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2.

@krysal, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday.

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

@krysal krysal merged commit de6707c into main Dec 19, 2023
41 checks passed
@krysal krysal deleted the update/alarms-runbooks branch December 19, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 aspect: text Concerns the textual material in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: documentation Related to Sphinx documentation
Projects
Archived in project
4 participants