Fix incorrect default production data refresh limit of 0

[stacimc]

Fixes

Description

#3232
The ingestion server allows setting a DATA_REFRESH_LIMIT used to cap the number of records processed in a data refresh. By default on production we don't have a limit. Historically we have represented this by setting the limit to 0. The copy data step has a simple if conditional before applying limits which meant that 0 was correctly considered "no limit".

When #3232 added logic to the reindexing step to also apply the record limit here, it did not have a similar check. The result is that in production, the default of 0 is applied... and 0 records are reindexed, effectively totally breaking the data refresh.

This PR:

• Adds a check to the index worker scheduler to only apply the record limit if in fact one has been set
• Changes the default limit in production from 0 to None, as this is more intuitive.

Testing Instructions

Locally, explicitly set DATA_REFRESH_LIMIT to None in your ingestion_server/.env to imitate production. Then run a data refresh and ensure that records make it all the way to the new es index.

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[sarayourfriend]

LGTM!

[AetherUnbound]

LGTM, I looked though this logic and thought we could get tripped up here but assumed that we'd be okay since the value would end up being None - alas!