Enforce braces for if-else and switch-case
#3474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
added
🟩 priority: low
obulat
requested changes
Dec 6, 2023
api/Pipfile.lock
Outdated
There was a problem hiding this comment.
Awesome start, @bhavik001. So many changes!
Could you revert the unrelated changes to the Pipfile.lock files?
obulat
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
I removed all of the unrelated changes (Pipfile.lock and pnpm lock file).
Thank you for your contribution, @bhavik001!
sarayourfriend
approved these changes
Dec 6, 2023
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
dhruvkb
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Changes LGTM, thanks for the contribution @bhavik001 and thanks @obulat for pushing this over the finish line!
| @@ -33,6 +33,8 @@ export const project: TSESLint.Linter.Config = { | |||
| semi: ["error", "never"], | |||
| "no-console": "off", | |||
| "unicorn/filename-case": ["error", { case: "kebabCase" }], | |||
| "unicorn/switch-case-braces": ["error"], | |||
There was a problem hiding this comment.
TIL about unicorn 🤦. This turned out to be quite straightforward.
dhruvkb
changed the title
if-else and switch-case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #3386 by @dhruvkb
This PR incorporates changes to the ESLint configuration to enforce the use of braces in one-line if-else statements and case blocks inside switch statements. This update aims to enhance code readability and prevent potential issues in the future. The specific ESLint rules added are:
Testing Instructions
pnpm run eslintpnpm run eslint --fixChecklist