Raise Exception for SVG Watermark

[firatbezir]

Fixes

Fixes #3373 by @obulat

Description

This checks if the URL ends with ".svg" or file type is an SVG and raises an UpstreamWatermarkException.

Testing Instructions

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[sarayourfriend]

Thanks for the contribution @firatbezir, it looks great so far. I just have two requests before I can approve:

1. Can you add a new unit test for this case? Existing watermark tests are in test_watermark.py.
2. Please run the linting locally with just lint and commit the changes. The linting CI step is failing and must pass before we can merge a PR.

[openverse-bot]

Based on the low urgency of this PR, the following reviewers are being gently reminded to review this PR:

@krysal
@stacimc
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend¹ days, this PR was ready for review 10 day(s) ago. PRs labelled with low urgency are expected to be reviewed within 5 weekday(s)².

@firatbezir, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

1. Specifically, Saturday and Sunday. ↩

2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range. ↩

[sarayourfriend]

Just a heads up, @firatbezir, I'm converting this to a draft to avoid the repeated pings until the unit test is present. Thanks again for the contribution, looking forward to being able to merge it 🙂

[obulat]

Thank you for your contribution, @firatbezir ! The CI passes :)

[firatbezir]

@obulat that is great. I truely owe you a big thank for your help and patience.

[AetherUnbound]

@firatbezir is it okay to reopen this? I think we still want these changes!

[firatbezir]

@AetherUnbound which changes did you mean?

[AetherUnbound]

This PR! It's closed but hasn't been merged yet. I'm going to reopen it so we can get the code merged in once it's reviewed 🙂

Changes have been addressed