-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert oembed to async #3458
Convert oembed to async #3458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the simplification around testing with pook is great to see, and this can def be used as an example for the future on how to make routes async!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It is very pleasant to see how simple the code and tests turned out.
7289ef4
to
4dbc304
Compare
@krysal Just a heads up, I had to change part of the way #3069 worked because async serializer support does not include |
This needs a more careful rebase. Drafting for now. |
6bddc10
to
1f59c5b
Compare
Linting Fix bad serializer reference Fix bad serializer reference
1f59c5b
to
dada13c
Compare
Fixes
Fixes #3457 by @sarayourfriend
Description
Converts the oembed endpoint to async. This was fairly straightforward and hopefully serves as a simpler example of the concept for others to work on additional views, if they wanted.
Testing Instructions
Unit tests should pass. Test the oembed endpoint as well and confirm it works the same as in staging.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin