Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix dynamically excluded providers caching" #3399

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Revert "Fix dynamically excluded providers caching" #3399

merged 1 commit into from
Nov 27, 2023

Conversation

sarayourfriend
Copy link
Collaborator

@sarayourfriend sarayourfriend commented Nov 27, 2023 •
edited
Loading

@sarayourfriend sarayourfriend added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: api Related to the Django API labels Nov 27, 2023
@sarayourfriend sarayourfriend requested a review from a team as a code owner November 27, 2023 04:30
dhruvkb
dhruvkb approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad to see a revert, is the resolution for the errors too complex to rollout as a hotfix?

@sarayourfriend
Copy link
Collaborator Author

Sad to see a revert, is the resolution for the errors too complex to rollout as a hotfix?

I haven't looked into it, honestly, and there are multiple parts of the code with problems, so in the interest of just being able to deploy the production API I think a revert is better. The original code change didn't address a critical problem, so there's no reason to rush to a solution.

@sarayourfriend sarayourfriend merged commit 6dd1aa3 into main Nov 27, 2023
71 checks passed
@sarayourfriend sarayourfriend deleted the revert-3381-fix/dynamically_excluded_providers branch November 27, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvkb dhruvkb dhruvkb approved these changes

@obulat obulat obulat approved these changes

@krysal krysal Awaiting requested review from krysal krysal is a code owner automatically assigned from WordPress/openverse-api

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: api Related to the Django API
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarayourfriend @obulat @dhruvkb