Remove this from VGridSkeleton props default

[Ashhar-24]

Fixes

Fixes #3268 by @Ashhar-24

Description

As mentioned in the issue #3268 that VGridSkeleton uses this in the props' default function and this causes a build error in Vue 3.
So I have moved default element count to the setup function and the numElems is replaced with elementCount in the template.

Note: if this PR is ready after #3322 is merged, this PR needs to remove the TODO from packages/eslint-plugin/src/configs/vue.ts:

    // TODO: disable after https://github.com/WordPress/openverse/issues/3268 is fixed
    "vue/no-deprecated-props-default-this": "off",

Testing Instructions

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[obulat]

Awesome work, @Ashhar-24 !
I think the only thing that's preventing the linting step in the CI is the any in the setup call. I added a suggestion how to fix it. If the CI passes after that fix, I'll approved this PR. Otherwise I'll level another review :)

[obulat]

Suggested change

	setup(props: { numElems: any; isForTab: string; }) {
	setup(props) {

The types of props are defined above, and we don't need to add any type information here.

[Ashhar-24]

Made the suggested changes.
But still the CI test is failing @obulat

[obulat]

You will need to run just lint and commit the changes.

[Ashhar-24]

You will need to run just lint and commit the changes.

This is error message that i'm receiveing.

[obulat]

I went ahead and committed the suggested changes, @Ashhar-24. Now it's ready to go 🚀

[dhruvkb]

LGTM! Thanks for the contribution @Ashhar-24!

[Ashhar-24]

Thank you @obulat for your constant support.
Was nice working with the issue.