-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source, creator and tag links to the single result page media info #3338
Merged
Merged
Changes from 28 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
5ff3eb9
Make chevron icons RTL-friendly
obulat eec9416
Add VByLine and VMediaInfo to SRP
obulat eb757de
Update snapshots
obulat 7c89759
Add items-center to audio full layout
obulat c905277
Fix tag spacing
obulat f468b52
Update scroll button spacings
obulat 49fbf7b
Update scroll button spacings
obulat 0b56efb
Update snapshots
obulat 0b0e167
Update fading
obulat 92b5665
Remove line-clamping for h1 and fix CTA placement
obulat 4f8f0f0
Improve scrolling
obulat 792afd0
Update snapshots
obulat df5ff4f
Make chevron icons RTL-friendly
obulat 00f81f5
Add VByLine and VMediaInfo to SRP
obulat ea04d83
Update snapshots
obulat 94e4f8a
Add items-center to audio full layout
obulat 31a8c41
Fix tag spacing
obulat dd35857
Update scroll button spacings
obulat ec7ac70
Update scroll button spacings
obulat 9c49d46
Update snapshots
obulat 7d23a73
Update fading
obulat f4c52f9
Remove line-clamping for h1 and fix CTA placement
obulat 890c33f
Improve scrolling
obulat 9a4c298
Update snapshots
obulat 42899f4
Merge branch 'additional_search_views/VByLine' of github.com:WordPres…
obulat f87a6b1
Remove unused variable
obulat 6d06265
Add more spacing to scroll buttons
obulat 2377d58
More fading
obulat 491d652
Fix scrolling edge-cases
obulat f82295a
Stop using the ui store for button variant
obulat 8a3f717
Add requested changes
obulat 0688cee
Merge branch 'main' into additional_search_views/VByLine
obulat 7c35d62
Remove scroll snap and update last 2 scrolls
obulat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
frontend/src/assets/svg/raw/chevron-left.svg → frontend/src/assets/svg/raw/chevron-back.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here we need to add here the
items-center
class to align all elements in the middle fromsm
to beyond. Otherwise they're top aligned, here is what I see.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing this synchronously, we decided to add a top margin of 4px to the CTA (Get media button) to make it well-balance both for single line titles and longer titles.