Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API integration test for the related endpoint #3331

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Nov 9, 2023

Fixes

Fixes the failure of related endpoint integration tests when the related items are selected by creator (when the title or tags query do not return any results). For an example see this test run on main (attempt 1): https://github.com/WordPress/openverse/actions/runs/6806564887/attempts/1

Description

This PR adds a check to see if the result is by the same creator (in addition to the checks that there are common words between the related result and the main item)

Marking this as "high" priority because without it, the API tests might be flaky.

Testing Instructions

The CI should pass and the changes should make sense.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner November 9, 2023 04:09
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: api Related to the Django API labels Nov 9, 2023
@obulat obulat self-assigned this Nov 9, 2023
@obulat obulat changed the title Add a check for the same creator Fix API integration test for the related endpoint Nov 9, 2023
@obulat obulat requested a review from dhruvkb November 9, 2023 07:17
@AetherUnbound AetherUnbound merged commit fa2fac4 into main Nov 9, 2023
67 checks passed
@AetherUnbound AetherUnbound deleted the fix/tests branch November 9, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants