Update nuxt, @nuxt/vue-app, @nuxt/types dependencies #3247

khushi-kothari · 2023-10-25T12:51:21Z

Fixes

Fixes #3242 by @obulat

Description

Updated nuxt dependency in frontend/package.json and updated the lock file, and commited the changes.

nuxt, @nuxt/vue-app, @nuxt/types: from 2.17.0 to ^2.17.2 [changes]

Testing Instructions

Checklist

My pull request has a descriptive title (not a vague title likeUpdate index.md).
My pull request targets the default branch of the repository (main) or a parent feature branch.
My commit messages follow best practices.
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no visible errors.
I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

obulat

Great start!

You will need to run just node-install at the root of the repository. This will update the lock file, pnpm-lock.yaml. After you commit this file, the linting should be fixed.

khushi-kothari · 2023-10-25T14:35:59Z

just node-install

@obulat After running just node-install, pnpm-lock.yaml was not updated. Can you point out what is the issue here?

obulat · 2023-10-25T15:14:55Z

@obulat After running just node-install, pnpm-lock.yaml was not updated. Can you point out what is the issue here?

I really don't understand why your lock file is updated, @khushi-kothari 😕

When I ran it locally on your branch, I got the following:

 j node-install                                                                                                                                                   ✔  8s  18:06:56 
pnpm i
Scope: all 4 workspace projects
readPackage: typescript@^4.9.5 => typescript@^4.9.5 in dependencies of @openverse/eslint-plugin
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated @npmcli/[email protected]
frontend                                 |  WARN  deprecated @npmcli/[email protected]
frontend                                 |  WARN  deprecated [email protected]
frontend                                 |  WARN  deprecated @babel/[email protected]
Packages: +258 -121
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------------------
Progress: resolved 2478, reused 2469, downloaded 0, added 1, done
node_modules/.pnpm/[email protected]_463pqhi6eauw3mjqcyq4fuonrm/node_modules/nuxt: Running postinstall script, done in 578ms
. postinstall$ pnpm --filter ./packages/* run build
│ No projects matched the filters in ".../openverse"
└─ Done in 338ms
Done in 20.1s
just frontend/run i18n:en
pnpm run i18n:en

> @openverse/[email protected] i18n:en .../openverse/frontend
> pnpm i18n:get-translations --en-only


> @openverse/[email protected] i18n:get-translations .../openverse/frontend
> node src/locales/scripts/get-translations "--en-only"

Successfully saved English translation to en.json.
just frontend/run i18n:copy-test-locales
pnpm run i18n:copy-test-locales

> @openverse/[email protected] i18n:copy-test-locales .../openverse/frontend
> cp -r test/locales/* src/locales/

.../openverse  nuxt *66 !1  git status                                                                                                                                                   ✔  22s  18:07:56 
On branch nuxt
Your branch is up to date with 'khushi-kothari/nuxt'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   pnpm-lock.yaml

no changes added to commit (use "git add" and/or "git commit -a")

(I redacted the openverse file paths)

I committed the lock file and pushed it to your branch.

Other options to try are running pnpm install --filter=frontend or running just install from the root (openverse/), but I'm not sure they would work better.

obulat · 2023-10-25T15:19:15Z

Hm, it looks like the vue packages need to be updated in the same PR after all, @khushi-kothari

vue, vue-server-renderer, vue-template-compiler: from 2.7.14 to ^2.7.15 changelog for 2.7.15

khushi-kothari · 2023-10-25T15:23:03Z

Ok @obulat that is the next task and am updating vue dependencies. Why are some of the CI tests failing in the current PR?

khushi-kothari · 2023-10-25T15:26:55Z

Thanks @obulat for adding lock file, I will look into what is causing this issue so next updates can be committed smoothly.

obulat · 2023-10-25T15:31:56Z

Ok @obulat that is the next task and am updating vue dependencies. Why are some of the CI tests failing in the current PR?

The CI tests are failing because the nuxt updates have updated one of the vue packages, and now there is a version mismatch and Nuxt cannot be built. So, the Vue dependencies should actually be updated in this PR instead of a separate PR.

khushi-kothari · 2023-10-25T16:00:20Z

@obulat Updated vue dependencies. Still 2 CI tests are failing.
Lock file updated this time and all changes added in the last commit that I added.

obulat · 2023-10-25T16:33:04Z

Weirdly, the lock file didn't fully match the updates in package.json, so the CI failed (you could see the messages about frozen lock file). I ran just install and committed the updated lock file. Let's see if the CI passes now :)

khushi-kothari · 2023-10-26T04:58:53Z

Hey @obulat I have added all tasks as individual PRs. Do you need any more help from my side on this issue #3242?

obulat · 2023-10-26T06:20:27Z

Hey @obulat I have added all tasks as individual PRs. Do you need any more help from my side on this issue #3242?

Hi, @khushi-kothari ! Thank you for creating the individual PRs. Could you please update them so that they only update the dependencies listed in the corresponding PR description?

For instance, Update focus-trap dependency should only update focus-trap, but if you look at the files changed, you can see that it updates all of these packages:

"@nuxtjs/i18n": "^7.3.1",
"@nuxtjs/sentry": "^7.5.0",
"@popperjs/core": "^2.11.8",
"@tailwindcss/typography": "^0.5.10",
"clipboard": "^2.0.11", "uuid": "^9.0.1",
"vue": "^2.7.15",
"@types/uuid": "^9.0.6",
"autoprefixer": "^10.4.16",
"tailwindcss": "^3.3.3",
"vue-demi": "^0.14.6",
"vue-server-renderer": "^2.7.15",
"vue-template-compiler": "^2.7.15",

obulat · 2023-10-26T06:54:55Z

@khushi-kothari, for this particular PR, we will need to either debug the way that Storybook is run in the CI now that Webpack added a patch for SSL, and Nuxt has removed its own patch (which is causing the CI to fail currently), or remove the smoke test from the CI. I'll ask other maintainers and write more here later.

khushi-kothari · 2023-10-26T13:13:10Z

Hey @obulat I think as it is linting problem always there is some issue while tracking whitespace changes. I locally have the following change for some reason it is not tracked while commiting.

local ss:

But while viewing it remotely, it is like this :

I followed following steps in this PR :

Checked out the lock file from main to remove all unrelated changes.
git checkout main -- pnpm-lock.yaml

Ran just node-install to update the lock file.

Committed the updated lock file to the branch and pushed the changes.

Yet, linting error is thrown.

obulat · 2023-10-26T13:40:24Z

Hey @obulat I think as it is linting problem always there is some issue while tracking whitespace changes. I locally have the following change for some reason it is not tracked while commiting.

I am not sure what's happening with the whitespace changes and why are they not tracked...
The lockfile changes, on the other hand, are not simply whitespace changes. In several PRs you can see that the Vue packages are still touched in the lock files, even though you reverted the Vue changes to the package.json file.
I could update the lock files for you if the process I described doesn't work for you locally:

I followed following steps in this PR :

Checked out the lock file from main to remove all unrelated changes.
git checkout main -- pnpm-lock.yaml
Ran just node-install to update the lock file.
Committed the updated lock file to the branch and pushed the changes.

khushi-kothari · 2023-10-26T14:15:38Z

Hey @obulat I think as it is linting problem always there is some issue while tracking whitespace changes. I locally have the following change for some reason it is not tracked while commiting.

I am not sure what's happening with the whitespace changes and why are they not tracked... The lockfile changes, on the other hand, are not simply whitespace changes. In several PRs you can see that the Vue packages are still touched in the lock files, even though you reverted the Vue changes to the package.json file. I could update the lock files for you if the process I described doesn't work for you locally:

I followed following steps in this PR :
Checked out the lock file from main to remove all unrelated changes.
git checkout main -- pnpm-lock.yaml
Ran just node-install to update the lock file.
Committed the updated lock file to the branch and pushed the changes.

Ya that will be very helpful @obulat as the process you described isn't working for me locally.

I hope my contributions were helpful. As my first experience to open sourcing, I could say I will continue doing it and will grow in the process. Thankyou for being the kindest mentor and guiding me through this issue very calmly.

obulat · 2023-10-26T15:14:02Z

Ya that will be very helpful @obulat as the process you described isn't working for me locally.

I hope my contributions were helpful. As my first experience to open sourcing, I could say I will continue doing it and will grow in the process. Thankyou for being the kindest mentor and guiding me through this issue very calmly.

Thank you for your contributions, @khushi-kothari, they are very helpful! Hope you can keep contributing with Openverse ❤️
It is often that dependency or local set up problems are more difficult than coding :)

Signed-off-by: Olga Bulat <[email protected]>

obulat · 2023-11-07T06:01:51Z

frontend/package.json

@@ -21,6 +21,7 @@
    "prod:playwright": "pnpm i18n:copy-test-locales && pnpm prod",
    "storybook": "nuxt storybook --port=54000",
    "storybook:build": "nuxt storybook build",
+    "storybook:build-for-docs": "NODE_OPTIONS=--openssl-legacy-provider nuxt storybook build",


This script is run in GitHub CI runner (not Docker), and without openssl-legacy-provider it fails.

Signed-off-by: Olga Bulat <[email protected]>

dhruvkb

LGTM!

khushi-kothari requested a review from a team as a code owner October 25, 2023 12:51

khushi-kothari requested review from AetherUnbound and obulat October 25, 2023 12:51

openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Oct 25, 2023

obulat requested changes Oct 25, 2023

View reviewed changes

khushi-kothari requested a review from obulat October 26, 2023 05:56

obulat marked this pull request as draft October 26, 2023 06:52

obulat mentioned this pull request Oct 26, 2023

Update frontend dependencies #3242

Closed

9 tasks

khushi-kothari changed the title ~~Updated nuxt, @nuxt/vue-app, @nuxt/types dependencies~~ Update nuxt, @nuxt/vue-app, @nuxt/types dependencies Oct 26, 2023

khushi-kothari mentioned this pull request Oct 26, 2023

Update Nuxt sentry dependency #3248

Merged

8 tasks

obulat mentioned this pull request Nov 6, 2023

Remove Storybook smoke test #3317

Merged

8 tasks

obulat marked this pull request as ready for review November 6, 2023 09:07

obulat requested a review from a team as a code owner November 6, 2023 09:07

obulat approved these changes Nov 6, 2023

View reviewed changes

obulat requested review from dhruvkb and removed request for AetherUnbound November 7, 2023 04:04

khushi-kothari and others added 3 commits November 7, 2023 07:17

Updated nuxt, @nuxt/vue-app, @nuxt/types dependencies

b6d7b6f

Update the lock file

616d584

Signed-off-by: Olga Bulat <[email protected]>

Use legacy openssl provider

02c6afc

Signed-off-by: Olga Bulat <[email protected]>

obulat reviewed Nov 7, 2023

View reviewed changes

Update root vue-tsc

39fa23a

Signed-off-by: Olga Bulat <[email protected]>

obulat mentioned this pull request Nov 8, 2023

Add some Vue 3 Eslint rules #3322

Merged

8 tasks

Merge branch 'main' into nuxt

610521b

dhruvkb approved these changes Nov 8, 2023

View reviewed changes

dhruvkb merged commit 3e62256 into WordPress:main Nov 8, 2023
46 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update nuxt, @nuxt/vue-app, @nuxt/types dependencies #3247

Update nuxt, @nuxt/vue-app, @nuxt/types dependencies #3247

khushi-kothari commented Oct 25, 2023 •

edited by obulat

Loading

obulat left a comment

khushi-kothari commented Oct 25, 2023 •

edited

Loading

obulat commented Oct 25, 2023

obulat commented Oct 25, 2023

khushi-kothari commented Oct 25, 2023

khushi-kothari commented Oct 25, 2023 •

edited

Loading

obulat commented Oct 25, 2023

khushi-kothari commented Oct 25, 2023 •

edited

Loading

obulat commented Oct 25, 2023

khushi-kothari commented Oct 26, 2023

obulat commented Oct 26, 2023

obulat commented Oct 26, 2023

khushi-kothari commented Oct 26, 2023

obulat commented Oct 26, 2023

khushi-kothari commented Oct 26, 2023 •

edited

Loading

obulat commented Oct 26, 2023

obulat Nov 7, 2023

dhruvkb left a comment

Update nuxt, @nuxt/vue-app, @nuxt/types dependencies #3247

Update nuxt, @nuxt/vue-app, @nuxt/types dependencies #3247

Conversation

khushi-kothari commented Oct 25, 2023 • edited by obulat Loading

Fixes

Description

Testing Instructions

Checklist

Developer Certificate of Origin

obulat left a comment

Choose a reason for hiding this comment

khushi-kothari commented Oct 25, 2023 • edited Loading

obulat commented Oct 25, 2023

obulat commented Oct 25, 2023

khushi-kothari commented Oct 25, 2023

khushi-kothari commented Oct 25, 2023 • edited Loading

obulat commented Oct 25, 2023

khushi-kothari commented Oct 25, 2023 • edited Loading

obulat commented Oct 25, 2023

khushi-kothari commented Oct 26, 2023

obulat commented Oct 26, 2023

obulat commented Oct 26, 2023

khushi-kothari commented Oct 26, 2023

obulat commented Oct 26, 2023

khushi-kothari commented Oct 26, 2023 • edited Loading

obulat commented Oct 26, 2023

obulat Nov 7, 2023

Choose a reason for hiding this comment

dhruvkb left a comment

Choose a reason for hiding this comment

khushi-kothari commented Oct 25, 2023 •

edited by obulat

Loading

khushi-kothari commented Oct 25, 2023 •

edited

Loading

khushi-kothari commented Oct 25, 2023 •

edited

Loading

khushi-kothari commented Oct 25, 2023 •

edited

Loading

khushi-kothari commented Oct 26, 2023 •

edited

Loading