-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add correct label to exclude #3214
Add correct label to exclude #3214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm not 100% sold on excluding project: proposal
and project: implementation plan
here as well 🤔 But I'm not opposed. I'll defer to other reviewers on that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for you help, @ngken0995. Let's keep this as the issue says and limit the exclusion to project threads.
.github/workflows/new_issues.yml
Outdated
@@ -19,7 +19,7 @@ jobs: | |||
project-url: https://github.com/orgs/WordPress/projects/75 | |||
github-token: ${{ secrets.ACCESS_TOKEN }} | |||
# Exclude the issues with the following labels | |||
labeled: project | |||
labeled: "🧭 project: thread, 🧭 project: proposal, 🧭 project: implementation plan" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
labeled: "🧭 project: thread, 🧭 project: proposal, 🧭 project: implementation plan" | |
labeled: "🧭 project: thread" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposals and implementations plans are issues that require PRs and reviews, so they shouldn't be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes
Fixes #445 by @obulat
Description
Replace
project
with🧭 project: thread, 🧭 project: proposal, 🧭 project: implementation plan
because there is a special board for the Projects and not in the backlog.Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin