Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use property attribute for OpenGraph title and image #3213

Merged
merged 19 commits into from
Oct 24, 2023
Merged

Use property attribute for OpenGraph title and image #3213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
cb71a1f
Change tags from using a name to a property attribute.
obiwanpelosi Oct 17, 2023
92d634c
change imported type to match the new fix
obiwanpelosi Oct 17, 2023
13aa01a
fix failed test
obiwanpelosi Oct 17, 2023
3bf49c4
fix test
obiwanpelosi Oct 17, 2023
b1d6f40
fix test
obiwanpelosi Oct 17, 2023
37d267e
fix test
obiwanpelosi Oct 17, 2023
e2acf94
fix test
obiwanpelosi Oct 17, 2023
667d153
fix test
obiwanpelosi Oct 17, 2023
8c81a4c
fix test
obiwanpelosi Oct 17, 2023
db04123
fix test
obiwanpelosi Oct 17, 2023
d7455cb
Lint
obulat Oct 19, 2023
b96dc36
fix failing test
obiwanpelosi Oct 19, 2023
bad22ce
Merge branch 'fix-issue-3211' of github.com:RogueCode007/openverse in…
obiwanpelosi Oct 19, 2023
65b8233
fix test
obiwanpelosi Oct 19, 2023
ba9adf2
fix test
obiwanpelosi Oct 19, 2023
fb763ea
revert changes
obiwanpelosi Oct 19, 2023
8d13dc5
fix test
obiwanpelosi Oct 20, 2023
16b498d
Merge branch 'main' of https://github.com/WordPress/openverse into fi…
obiwanpelosi Oct 20, 2023
77427e1
Merge branch 'main' into fix-issue-3211
obiwanpelosi Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/constants/meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ export const meta = [
name: "description",
content: DESCRIPTION,
},
{ hid: "og:title", name: "og:title", content: "Openverse" },
{ hid: "og:title", property: "og:title", content: "Openverse" },
{
hid: "og:image",
name: "og:image",
property: "og:image",
content: "/openverse-default.jpg",
},
{
Expand Down
11 changes: 7 additions & 4 deletions frontend/src/utils/og.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import type { MetaInfo } from "vue-meta"
import type { MetaPropertyName } from "vue-meta/types/vue-meta"
import type {
MetaPropertyName,
MetaPropertyProperty,
} from "vue-meta/types/vue-meta"

export const createDetailPageMeta = ({
title,
Expand All @@ -18,18 +21,18 @@ export const createDetailPageMeta = ({
name: "robots",
content: "noindex",
},
] as MetaPropertyName[]
] as (MetaPropertyName | MetaPropertyProperty)[]
if (title) {
meta.push({
hid: "og:title",
name: "og:title",
property: "og:title",
content: title,
})
}
if (thumbnail && !isSensitive) {
meta.push({
hid: "og:image",
name: "og:image",
property: "og:image",
content: thumbnail,
})
}
Expand Down
4 changes: 2 additions & 2 deletions frontend/test/playwright/e2e/seo.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ test.describe("Page metadata", () => {
const metaRobots = page.locator('meta[name="robots"]')
await expect(metaRobots).toHaveAttribute("content", openversePage.robots)

const metaOgImage = page.locator('meta[name="og:image"]')
const metaOgImage = page.locator('meta[property="og:image"]')
await expect(metaOgImage).toHaveAttribute(
"content",
openversePage.ogImage
)

const metaOgTitle = page.locator('meta[name="og:title"]')
const metaOgTitle = page.locator('meta[property="og:title"]')
await expect(metaOgTitle).toHaveAttribute(
"content",
openversePage.ogTitle
Expand Down
Loading