Add VByLine component #3164

obulat · 2023-10-07T11:33:10Z

Fixes

Fixes #2730 by @obulat

Description

Testing Instructions

Checklist

My pull request has a descriptive title (not a vague title likeUpdate index.md).
My pull request targets the default branch of the repository (main) or a parent feature branch.
My commit messages follow best practices.
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no visible errors.
I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

github-actions · 2023-10-07T11:39:31Z

Size Change: +7.79 kB (+1%)

Total Size: 946 kB

Filename	Size	Change
`./frontend/.nuxt/dist/client/242.js`	0 B	-342 B (removed)	🏆
`./frontend/.nuxt/dist/client/242.modern.js`	0 B	-346 B (removed)	🏆
`./frontend/.nuxt/dist/client/243.js`	342 B	-1.51 kB (-82%)	🏆
`./frontend/.nuxt/dist/client/app.js`	124 kB	+174 B (0%)
`./frontend/.nuxt/dist/client/app.modern.js`	115 kB	+88 B (0%)
`./frontend/.nuxt/dist/client/components/v-sources-table.js`	14.9 kB	+63 B (0%)
`./frontend/.nuxt/dist/client/components/v-sources-table.modern.js`	14.9 kB	+63 B (0%)
`./frontend/.nuxt/dist/client/pages/audio/_id/index.js`	17.4 kB	+22 B (0%)
`./frontend/.nuxt/dist/client/pages/image/_id/index.js`	17.3 kB	+1.57 kB (+10%)	⚠️
`./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js`	16 kB	+1.28 kB (+9%)	🔍
`./frontend/.nuxt/dist/client/pages/image/_id/report.js`	5 kB	+32 B (+1%)
`./frontend/.nuxt/dist/client/runtime.js`	2.82 kB	+15 B (+1%)
`./frontend/.nuxt/dist/client/runtime.modern.js`	2.82 kB	+15 B (+1%)
`./frontend/.nuxt/dist/client/vendors/app.js`	68.8 kB	+477 B (+1%)
`./frontend/.nuxt/dist/client/vendors/app.modern.js`	68.6 kB	+489 B (+1%)
`./frontend/.nuxt/dist/client/243.modern.js`	346 B	+346 B (new file)	🆕
`./frontend/.nuxt/dist/client/244.js`	1.85 kB	+1.85 kB (new file)	🆕
`./frontend/.nuxt/dist/client/components/v-by-line.js`	1.74 kB	+1.74 kB (new file)	🆕
`./frontend/.nuxt/dist/client/components/v-by-line.modern.js`	1.73 kB	+1.73 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size	Change
`./frontend/.nuxt/dist/client/commons/app.js`	90 kB	0 B
`./frontend/.nuxt/dist/client/commons/app.modern.js`	81 kB	0 B
`./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/e4094511.js`	5.18 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/e4094511.modern.js`	5.62 kB	0 B
`./frontend/.nuxt/dist/client/components/loading-icon.js`	733 B	+5 B (+1%)
`./frontend/.nuxt/dist/client/components/loading-icon.modern.js`	734 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/table-sort-icon.js`	515 B	0 B
`./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js`	519 B	0 B
`./frontend/.nuxt/dist/client/components/v-all-results-grid.js`	6.82 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js`	6.64 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-collection.js`	4.51 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-collection.modern.js`	4.38 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-control.js`	1.51 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-control.modern.js`	1.5 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-list.js`	1.44 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-list.modern.js`	1.42 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-result.js`	1.12 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-result.modern.js`	1.1 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js`	959 B	0 B
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js`	961 B	0 B
`./frontend/.nuxt/dist/client/components/v-audio-track.js`	6.97 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-track.modern.js`	6.93 kB	0 B
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js`	634 B	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js`	638 B	-5 B (-1%)
`./frontend/.nuxt/dist/client/components/v-bone.js`	632 B	0 B
`./frontend/.nuxt/dist/client/components/v-bone.modern.js`	636 B	0 B
`./frontend/.nuxt/dist/client/components/v-box-layout.js`	1.35 kB	0 B
`./frontend/.nuxt/dist/client/components/v-box-layout.modern.js`	1.35 kB	0 B
`./frontend/.nuxt/dist/client/components/v-collection-header.js`	1.3 kB	+3 B (0%)
`./frontend/.nuxt/dist/client/components/v-collection-header.modern.js`	1.31 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-link.js`	1.07 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-link.modern.js`	1.06 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-page.js`	531 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-page.modern.js`	534 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.js`	492 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js`	496 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-form.js`	3.33 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js`	3.21 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-report-popover.js`	3.79 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js`	3.67 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-button.js`	3.99 kB	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-copy-button.modern.js`	4 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-license.js`	2.34 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-copy-license.modern.js`	2.31 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-dmca-notice.js`	795 B	0 B
`./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js`	799 B	0 B
`./frontend/.nuxt/dist/client/components/v-error-image.js`	2.51 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-error-image.modern.js`	2.48 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-error-section.js`	5.21 kB	0 B
`./frontend/.nuxt/dist/client/components/v-error-section.modern.js`	4.58 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-external-search-form.js`	4.1 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js`	3.44 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-external-source-list.js`	2.63 kB	0 B
`./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js`	1.99 kB	0 B
`./frontend/.nuxt/dist/client/components/v-full-layout.js`	1.91 kB	+3 B (0%)
`./frontend/.nuxt/dist/client/components/v-full-layout.modern.js`	1.91 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-get-media-button.js`	622 B	0 B
`./frontend/.nuxt/dist/client/components/v-get-media-button.modern.js`	628 B	0 B
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.js`	1.53 kB	0 B
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js`	1.53 kB	0 B
`./frontend/.nuxt/dist/client/components/v-hide-button.js`	576 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-hide-button.modern.js`	573 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-home-gallery.js`	4.28 kB	0 B
`./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js`	4.26 kB	0 B
`./frontend/.nuxt/dist/client/components/v-homepage-content.js`	1.82 kB	0 B
`./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js`	1.79 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-image-cell.js`	2.24 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-image-cell.modern.js`	2.23 kB	+3 B (0%)
`./frontend/.nuxt/dist/client/components/v-image-grid.js`	4.51 kB	+5 B (0%)
`./frontend/.nuxt/dist/client/components/v-image-grid.modern.js`	4.39 kB	+5 B (0%)
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.js`	643 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js`	649 B	0 B
`./frontend/.nuxt/dist/client/components/v-load-more.js`	1.18 kB	0 B
`./frontend/.nuxt/dist/client/components/v-load-more.modern.js`	1.07 kB	0 B
`./frontend/.nuxt/dist/client/components/v-media-details.js`	5.8 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-media-details.modern.js`	5.65 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/components/v-media-license.js`	931 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-license.modern.js`	940 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-reuse.js`	3 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js`	2.97 kB	0 B
`./frontend/.nuxt/dist/client/components/v-media-tag.js`	416 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-tag.modern.js`	420 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-tags.js`	831 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-tags.modern.js`	825 B	0 B
`./frontend/.nuxt/dist/client/components/v-metadata-value.js`	587 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-metadata-value.modern.js`	593 B	0 B
`./frontend/.nuxt/dist/client/components/v-metadata.js`	1.3 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-metadata.modern.js`	1.31 kB	0 B
`./frontend/.nuxt/dist/client/components/v-modal.js`	981 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-modal.modern.js`	973 B	0 B
`./frontend/.nuxt/dist/client/components/v-no-results.js`	2.67 kB	0 B
`./frontend/.nuxt/dist/client/components/v-no-results.modern.js`	2.03 kB	0 B
`./frontend/.nuxt/dist/client/components/v-radio.js`	1 kB	0 B
`./frontend/.nuxt/dist/client/components/v-radio.modern.js`	1.01 kB	0 B
`./frontend/.nuxt/dist/client/components/v-related-audio.js`	825 B	0 B
`./frontend/.nuxt/dist/client/components/v-related-audio.modern.js`	742 B	0 B
`./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.js`	4.5 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.modern.js`	4.37 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-related-images.js`	803 B	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-related-images.modern.js`	720 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-report-desc-form.js`	977 B	0 B
`./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js`	980 B	0 B
`./frontend/.nuxt/dist/client/components/v-row-layout.js`	1.72 kB	0 B
`./frontend/.nuxt/dist/client/components/v-row-layout.modern.js`	1.72 kB	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-safety-wall.js`	1.44 kB	0 B
`./frontend/.nuxt/dist/client/components/v-safety-wall.modern.js`	1.44 kB	0 B
`./frontend/.nuxt/dist/client/components/v-scroll-button.js`	892 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js`	891 B	0 B
`./frontend/.nuxt/dist/client/components/v-search-results-title.js`	619 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js`	621 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-single-result-controls.js`	1.17 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-single-result-controls.modern.js`	1.17 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js`	1.02 kB	0 B
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js`	915 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-snackbar.js`	1.07 kB	0 B
`./frontend/.nuxt/dist/client/components/v-snackbar.modern.js`	1.07 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-tag.js`	412 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-tag.modern.js`	416 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.js`	306 B	0 B
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js`	311 B	0 B
`./frontend/.nuxt/dist/client/pages/about.js`	1.42 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/pages/about.modern.js`	1.42 kB	0 B
`./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js`	16.4 kB	+8 B (0%)
`./frontend/.nuxt/dist/client/pages/feedback.js`	1.36 kB	0 B
`./frontend/.nuxt/dist/client/pages/feedback.modern.js`	1.36 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js`	4.73 kB	0 B
`./frontend/.nuxt/dist/client/pages/index.js`	6.38 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/pages/index.modern.js`	6.35 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/preferences.js`	1.46 kB	-2 B (0%)
`./frontend/.nuxt/dist/client/pages/preferences.modern.js`	1.46 kB	0 B
`./frontend/.nuxt/dist/client/pages/privacy.js`	1.26 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/privacy.modern.js`	1.26 kB	0 B
`./frontend/.nuxt/dist/client/pages/search-help.js`	1.62 kB	0 B
`./frontend/.nuxt/dist/client/pages/search-help.modern.js`	1.61 kB	0 B
`./frontend/.nuxt/dist/client/pages/search.js`	5.78 kB	0 B
`./frontend/.nuxt/dist/client/pages/search.modern.js`	8.14 kB	+4 B (0%)
`./frontend/.nuxt/dist/client/pages/search/audio.js`	499 B	0 B
`./frontend/.nuxt/dist/client/pages/search/audio.modern.js`	503 B	0 B
`./frontend/.nuxt/dist/client/pages/search/image.js`	453 B	0 B
`./frontend/.nuxt/dist/client/pages/search/image.modern.js`	454 B	0 B
`./frontend/.nuxt/dist/client/pages/search/index.js`	315 B	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/index.modern.js`	320 B	0 B
`./frontend/.nuxt/dist/client/pages/search/model-3d.js`	243 B	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js`	246 B	0 B
`./frontend/.nuxt/dist/client/pages/search/video.js`	240 B	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/video.modern.js`	243 B	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/sensitive-content.js`	1.53 kB	0 B
`./frontend/.nuxt/dist/client/pages/sensitive-content.modern.js`	1.53 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/sources.js`	1.53 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/sources.modern.js`	1.54 kB	0 B

_{compressed-size-action}

github-actions · 2023-10-07T11:51:10Z

Full-stack documentation: https://docs.openverse.org/_preview/3164

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

github-actions bot added 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend labels Oct 7, 2023

openverse-bot added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 🕹 aspect: interface Concerns end-users' experience with the software labels Oct 7, 2023

obulat force-pushed the add/VByLine branch from c9b647f to 1498c1f Compare October 11, 2023 06:31

obulat changed the base branch from main to update/full-layout October 11, 2023 06:52

obulat mentioned this pull request Oct 11, 2023

Fix single result page test flakiness #3186

Merged

8 tasks

obulat force-pushed the update/full-layout branch 6 times, most recently from b7cb9b1 to aa3aad4 Compare October 12, 2023 11:31

obulat force-pushed the add/VByLine branch from 1498c1f to 9003c9c Compare October 12, 2023 12:40

obulat force-pushed the update/full-layout branch 2 times, most recently from 46c5a19 to b33fdf1 Compare October 18, 2023 07:19

obulat added 11 commits October 18, 2023 16:49

Add tests for additional search views single result page

0800379

Add snapshots

7d364ad

Add tapes for single result thumbnails

4925b68

Update snapshots

ab7fdb8

Add wait for h1 to make sure that the page has navigated

3bbe61f

Update the full audio track

2ee24cc

Put updated single audio detail page changes behind flag

0d70a65

Update snapshot

667e6ed

Update xs VGetMediaButton and h1 styles

23a9bc8

Update xs snapshots

40e1c81

Update pages single result pw test

5e394b5

obulat added 2 commits October 18, 2023 16:49

Revert tape changes

54897b9

Update snapshots (new tags)

815a71e

obulat force-pushed the update/full-layout branch from 7aa2e73 to 815a71e Compare October 18, 2023 13:51

obulat added 3 commits October 18, 2023 17:02

Rename chevrons to make them RTL-friendly

53f5c73

Add VByLine under the feature flag

c41dbc0

Update image result snapshots

6b265be

obulat force-pushed the add/VByLine branch from 9003c9c to 6b265be Compare October 18, 2023 14:27

obulat force-pushed the update/full-layout branch from 815a71e to e61a628 Compare October 18, 2023 17:16

Base automatically changed from update/full-layout to main October 19, 2023 09:17

obulat closed this Oct 27, 2023

obulat deleted the add/VByLine branch January 4, 2024 07:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add VByLine component #3164

Add VByLine component #3164

obulat commented Oct 7, 2023

github-actions bot commented Oct 7, 2023 •

edited

Loading

github-actions bot commented Oct 7, 2023

Add VByLine component #3164

Add VByLine component #3164

Conversation

obulat commented Oct 7, 2023

Fixes

Description

Testing Instructions

Checklist

Developer Certificate of Origin

github-actions bot commented Oct 7, 2023 • edited Loading

github-actions bot commented Oct 7, 2023

github-actions bot commented Oct 7, 2023 •

edited

Loading