Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter languages by presence of ISO #3017

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Filter languages by presence of ISO #3017

merged 1 commit into from
Sep 12, 2023

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Sep 12, 2023

Fixes

Fixes #2986 by @obulat

Description

This PR filters locales by the presence of the iso field instead of the code field, because the ISO is used to generate SEO links and sitemaps etc.

Testing Instructions

  1. Run the dev server.
  2. Observe the number of languages in the locale chooser (it should be ~200).
  3. Observe the presence of languages like Emoji and भोजपुरी (they should appear).
  4. Check out the PR and restart the dev server.
  5. Observe the number of languages drop to ~160.
  6. Observe that Emoji and भोजपुरी have disappeared.
  7. Observe that warning from @nuxt/i18n are not being logged.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner September 12, 2023 06:11
@github-actions github-actions bot added 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend labels Sep 12, 2023
@openverse-bot openverse-bot added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Sep 12, 2023
@github-actions
Copy link

Size Change: -9.18 kB (-1%)

Total Size: 886 kB

Filename Size Change
./frontend/.nuxt/dist/client/276.js 0 B -343 B (removed) 🏆
./frontend/.nuxt/dist/client/276.modern.js 0 B -347 B (removed) 🏆
./frontend/.nuxt/dist/client/277.js 0 B -1.85 kB (removed) 🏆
./frontend/.nuxt/dist/client/app.js 123 kB -4.19 kB (-3%)
./frontend/.nuxt/dist/client/app.modern.js 114 kB -4.36 kB (-4%)
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 10.7 kB -81 B (-1%)
./frontend/.nuxt/dist/client/pages/image/_id/index.js 9.45 kB -55 B (-1%)
./frontend/.nuxt/dist/client/pages/image/_id/report.js 4.96 kB -29 B (-1%)
./frontend/.nuxt/dist/client/pages/index.js 6.38 kB -28 B (0%)
./frontend/.nuxt/dist/client/pages/search.js 4.76 kB -27 B (-1%)
./frontend/.nuxt/dist/client/runtime.js 2.77 kB -203 B (-7%) ✅
./frontend/.nuxt/dist/client/runtime.modern.js 2.78 kB -203 B (-7%) ✅
./frontend/.nuxt/dist/client/238.js 343 B +343 B (new file) 🆕
./frontend/.nuxt/dist/client/238.modern.js 347 B +347 B (new file) 🆕
./frontend/.nuxt/dist/client/239.js 1.85 kB +1.85 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./frontend/.nuxt/dist/client/commons/app.js 90 kB 0 B
./frontend/.nuxt/dist/client/commons/app.modern.js 81 kB 0 B
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/98a81936.js 5.18 kB 0 B
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/98a81936.modern.js 5.62 kB 0 B
./frontend/.nuxt/dist/client/components/loading-icon.js 729 B -3 B (0%)
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 734 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.js 514 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 519 B 0 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 6.62 kB 0 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 6.46 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-collection.js 4.41 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-collection.modern.js 4.29 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-control.js 1.51 kB +4 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-control.modern.js 1.5 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-list.js 1.32 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-list.modern.js 1.31 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-result.js 1 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-result.modern.js 994 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 959 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 960 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.7 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.66 kB 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 636 B 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 642 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.js 632 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 635 B 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.35 kB 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.35 kB 0 B
./frontend/.nuxt/dist/client/components/v-collection-header.js 1.31 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-collection-header.modern.js 1.31 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-content-link.js 1.07 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.06 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-page.js 530 B 0 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 534 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 492 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 497 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.33 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.21 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 3.79 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 3.67 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-button.js 3.99 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.js 2.33 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 2.31 kB 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 793 B 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 797 B 0 B
./frontend/.nuxt/dist/client/components/v-error-image.js 2.51 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 2.47 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-section.js 5.21 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 4.58 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.js 4.1 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 3.44 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.js 2.63 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 1.99 kB 0 B
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.57 kB 0 B
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.57 kB 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.54 kB 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.54 kB 0 B
./frontend/.nuxt/dist/client/components/v-hide-button.js 576 B 0 B
./frontend/.nuxt/dist/client/components/v-hide-button.modern.js 574 B 0 B
./frontend/.nuxt/dist/client/components/v-home-gallery.js 4.28 kB 0 B
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 4.26 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.82 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.79 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.js 1.95 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 1.94 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-grid.js 4.43 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 4.3 kB 0 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 642 B 0 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 650 B 0 B
./frontend/.nuxt/dist/client/components/v-load-more.js 1.17 kB 0 B
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 1.07 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-details.js 2.31 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-details.modern.js 2.28 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-details/pages/image/_id/index.js 3.79 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-details/pages/image/_id/index.modern.js 3.67 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-license.js 930 B 0 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 939 B 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 2.99 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 2.96 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.js 416 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 420 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tags.js 588 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tags.modern.js 587 B 0 B
./frontend/.nuxt/dist/client/components/v-metadata.js 937 B 0 B
./frontend/.nuxt/dist/client/components/v-metadata.modern.js 939 B 0 B
./frontend/.nuxt/dist/client/components/v-modal.js 982 B 0 B
./frontend/.nuxt/dist/client/components/v-modal.modern.js 973 B 0 B
./frontend/.nuxt/dist/client/components/v-no-results.js 2.67 kB 0 B
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 2.03 kB 0 B
./frontend/.nuxt/dist/client/components/v-radio.js 1 kB 0 B
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.js 824 B 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 741 B 0 B
./frontend/.nuxt/dist/client/components/v-related-images.js 805 B 0 B
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 719 B 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 977 B 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 980 B 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.72 kB 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.73 kB 0 B
./frontend/.nuxt/dist/client/components/v-safety-wall.js 1.44 kB 0 B
./frontend/.nuxt/dist/client/components/v-safety-wall.modern.js 1.44 kB 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.js 891 B 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 890 B 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.js 618 B 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 623 B 0 B
./frontend/.nuxt/dist/client/components/v-single-result-controls.js 1.17 kB 0 B
./frontend/.nuxt/dist/client/components/v-single-result-controls.modern.js 1.17 kB 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.02 kB 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 915 B 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.07 kB 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.08 kB 0 B
./frontend/.nuxt/dist/client/components/v-sources-table.js 14.6 kB 0 B
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 14.6 kB 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B 0 B
./frontend/.nuxt/dist/client/pages/about.js 1.42 kB 0 B
./frontend/.nuxt/dist/client/pages/about.modern.js 1.42 kB 0 B
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 10.4 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/feedback.js 1.36 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.36 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 9.21 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.73 kB 0 B
./frontend/.nuxt/dist/client/pages/index.modern.js 6.35 kB 0 B
./frontend/.nuxt/dist/client/pages/preferences.js 1.46 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.45 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/privacy.js 1.26 kB +2 B (0%)
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.26 kB 0 B
./frontend/.nuxt/dist/client/pages/search-help.js 1.62 kB -2 B (0%)
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.61 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/search.modern.js 4.56 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/audio.js 502 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 507 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/image.js 461 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/image.modern.js 462 B 0 B
./frontend/.nuxt/dist/client/pages/search/index.js 315 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/index.modern.js 316 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/model-3d.js 242 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 245 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/video.js 240 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 243 B 0 B
./frontend/.nuxt/dist/client/pages/sources.js 1.53 kB 0 B
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.54 kB +1 B (0%)
./frontend/.nuxt/dist/client/vendors/app.js 68.3 kB 0 B
./frontend/.nuxt/dist/client/vendors/app.modern.js 68 kB 0 B

compressed-size-action

@github-actions
Copy link

Full-stack documentation: https://docs.openverse.org/_preview/3017

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

obulat
obulat approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any locales that don't have code? Maybe it's safer to filter on both:
(l) => Boolean(l.code && l.iso) ?

@dhruvkb
Copy link
Member Author

dhruvkb commented Sep 12, 2023

The code field is always present.

@dhruvkb dhruvkb merged commit 539135e into main Sep 12, 2023
@dhruvkb dhruvkb deleted the fix_iso branch September 12, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarayourfriend sarayourfriend sarayourfriend approved these changes

@obulat obulat obulat approved these changes

@AetherUnbound AetherUnbound Awaiting requested review from AetherUnbound AetherUnbound is a code owner automatically assigned from WordPress/openverse-frontend

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning from @nuxtjs/i18n about locales without ISO code
4 participants
@dhruvkb @obulat @sarayourfriend @openverse-bot