Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redlock-py from api dependencies #3004

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

rwidom
Copy link
Collaborator

@rwidom rwidom commented Sep 10, 2023

Fixes

Fixes #2893 by @sarayourfriend

Description

Removed the redlock-py dependency from the api pipfile, and then ran pipenv install to update the lock file accordingly.

Testing Instructions

Check out the branch and run

just api/wait-up
just api/init
just api/test
just api/stats

Then try api calls locally to be sure, such as curl "http://localhost:50280/v1/images/?q=pip"

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@github-actions github-actions bot added the 🧱 stack: api Related to the Django API label Sep 10, 2023
@openverse-bot openverse-bot added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Sep 10, 2023
@rwidom rwidom marked this pull request as ready for review September 10, 2023 15:31
@rwidom rwidom requested a review from a team as a code owner September 10, 2023 15:31
@sarayourfriend
Copy link
Collaborator

Rebasing this one.

@sarayourfriend sarayourfriend force-pushed the fix-2893/Remove-redlockpy-dependency-from-API branch from 579ebf9 to 35be6da Compare September 11, 2023 03:41
@obulat obulat force-pushed the fix-2893/Remove-redlockpy-dependency-from-API branch from 35be6da to 6711ee0 Compare September 11, 2023 07:34
@obulat obulat merged commit 9294964 into main Sep 11, 2023
44 checks passed
@obulat obulat deleted the fix-2893/Remove-redlockpy-dependency-from-API branch September 11, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove redlock-py dependency from API
4 participants