-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runbooks for API response times alarms #3001
Conversation
bc09b1a
to
327e443
Compare
327e443
to
f69a7f8
Compare
Full-stack documentation: https://docs.openverse.org/_preview/3001 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. New files ➕:
Changed files 🔄: |
f69a7f8
to
08407a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like both of these runbooks are largely identical in content (as they should be, they're both for response times and likely to co-occur frequently). Can they both be combined into a single runbook instead?
That's an infra change, which might delay things, so I'm approving this to unblock. LGTM!
6adedf9
to
051b2d9
Compare
Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR: @obulat Excluding weekend1 days, this PR was ready for review 6 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2. @krysal, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links should be updated, and probably the heading.
documentation/meta/monitoring/runbooks/api_avg_response_time_above_threshold.md
Outdated
Show resolved
Hide resolved
documentation/meta/monitoring/runbooks/api_p99_response_time_above_threshold.md
Outdated
Show resolved
Hide resolved
documentation/meta/monitoring/runbooks/api_p99_response_time_above_threshold.md
Outdated
Show resolved
Hide resolved
b05c01f
to
76adc28
Compare
@obulat I added the runbooks for the anomaly response alarms (WordPress/openverse-infrastructure#622), I'll await your review on this. |
f57cfe7
to
8f53e8c
Compare
Fixes
Related to #2501 by @sarayourfriend
Description
Adds the run books for the general API response time alarms.
Testing Instructions
Look for the preview in the comments and check that the instructions make sense.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin