Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise runbooks for Nuxt 2XX/5XX alarms #2974

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Sep 4, 2023

Fixes

Related to WordPress/openverse-infrastructure#606 by @dhruvkb

Description

This PR adds runbooks for the alarms added in the above linked PR.

Testing Instructions

Read the documentation pages from the preview site.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 📄 aspect: text Concerns the textual material in the repository 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: infra Related to the Terraform config and other infrastructure labels Sep 4, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Full-stack documentation: https://docs.openverse.org/_preview/2974

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

New files ➕:

Changed files 🔄:

@dhruvkb dhruvkb added this to the ECS Alarms milestone Sep 7, 2023
@dhruvkb dhruvkb mentioned this pull request Sep 7, 2023
6 tasks
@dhruvkb dhruvkb marked this pull request as ready for review September 8, 2023 10:45
@dhruvkb dhruvkb requested a review from a team as a code owner September 8, 2023 10:45
@dhruvkb dhruvkb requested review from fcoveram and stacimc September 8, 2023 10:45
@krysal krysal removed the request for review from fcoveram September 8, 2023 13:40
@krysal krysal removed this from the ECS Alarms milestone Sep 8, 2023
@krysal krysal mentioned this pull request Sep 8, 2023
1 task
@dhruvkb dhruvkb requested a review from krysal September 11, 2023 22:05
@dhruvkb
Copy link
Member Author

dhruvkb commented Sep 12, 2023

Update: The alarms have been merged into main and applied in prod so the runbooks should be added to the docs soon.

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👍

@dhruvkb dhruvkb merged commit 634b977 into main Sep 14, 2023
@dhruvkb dhruvkb deleted the nuxt_2xx_5xx_runbooks branch September 14, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 aspect: text Concerns the textual material in the repository 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: infra Related to the Terraform config and other infrastructure
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants