Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to tailwind config viewer from docs #2827

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Remove reference to tailwind config viewer from docs #2827

merged 1 commit into from
Aug 14, 2023

Conversation

sarayourfriend
Copy link
Collaborator

Fixes

Fast follow to #2490.

Description

The linked PR removes the tailwind config viewer because it is not compatible with TypeScript, so we should remove the reference to that page from our docs.

Testing Instructions

Confirm I haven't missed anywhere else we need to remove references to TCV.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • [N/A] I tried running the project locally and verified that there are no visible errors.
  • [N/A] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend
Remove reference to tailwind config viewer from docs
d409753 
Fast follow to #2490. That PR removes the tailwind config viewer because it is not compatible with TypeScript, so we should remove the reference to that page from our docs.
@sarayourfriend sarayourfriend added 🟨 priority: medium Not blocking but should be addressed soon 📄 aspect: text Concerns the textual material in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: frontend Related to the Nuxt frontend labels Aug 14, 2023
@sarayourfriend sarayourfriend requested a review from a team as a code owner August 14, 2023 06:47
@github-actions github-actions bot added the 🧱 stack: documentation Related to Sphinx documentation label Aug 14, 2023
@github-actions
Copy link

Size Change: -20.7 kB (-2%)

Total Size: 847 kB

Filename Size Change
./frontend/.nuxt/dist/client/238.js 0 B -272 B (removed) 🏆
./frontend/.nuxt/dist/client/238.modern.js 0 B -277 B (removed) 🏆
./frontend/.nuxt/dist/client/239.js 0 B -1.85 kB (removed) 🏆
./frontend/.nuxt/dist/client/app.js 112 kB -9.97 kB (-8%) ✅
./frontend/.nuxt/dist/client/app.modern.js 103 kB -9.9 kB (-9%) ✅
./frontend/.nuxt/dist/client/runtime.js 2.33 kB -423 B (-15%) 👏
./frontend/.nuxt/dist/client/runtime.modern.js 2.33 kB -422 B (-15%) 👏
./frontend/.nuxt/dist/client/156.js 273 B +273 B (new file) 🆕
./frontend/.nuxt/dist/client/156.modern.js 277 B +277 B (new file) 🆕
./frontend/.nuxt/dist/client/157.js 1.85 kB +1.85 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./frontend/.nuxt/dist/client/commons/app.js 90.5 kB 0 B
./frontend/.nuxt/dist/client/commons/app.modern.js 81.1 kB 0 B
./frontend/.nuxt/dist/client/commons/components/v-search-grid/pages/search.js 5.17 kB 0 B
./frontend/.nuxt/dist/client/commons/components/v-search-grid/pages/search.modern.js 5.61 kB 0 B
./frontend/.nuxt/dist/client/components/loading-icon.js 728 B 0 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 734 B +1 B (0%)
./frontend/.nuxt/dist/client/components/table-sort-icon.js 515 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 519 B 0 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 6.61 kB 0 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 6.46 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-collection.js 4.38 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-collection.modern.js 4.26 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-details.js 1.79 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-details.modern.js 1.77 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-list.js 1.32 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-list.modern.js 1.31 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-result.js 1 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-result.modern.js 995 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 958 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 961 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.67 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.63 kB 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 634 B 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 640 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.js 632 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 636 B 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.33 kB 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.33 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-link.js 1.06 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.06 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-page.js 531 B 0 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 535 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 493 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 497 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.33 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.21 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 3.79 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 3.67 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-button.js 3.99 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.js 2.27 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 2.25 kB 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 793 B 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 797 B 0 B
./frontend/.nuxt/dist/client/components/v-error-image.js 2.41 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 2.38 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-section.js 372 B 0 B
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 376 B 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.js 2 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 1.98 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.js 896 B 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 894 B 0 B
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.57 kB 0 B
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.57 kB 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.52 kB 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.53 kB 0 B
./frontend/.nuxt/dist/client/components/v-hide-button.js 812 B 0 B
./frontend/.nuxt/dist/client/components/v-hide-button.modern.js 815 B 0 B
./frontend/.nuxt/dist/client/components/v-home-gallery.js 4.28 kB 0 B
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 4.26 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.8 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.77 kB 0 B
./frontend/.nuxt/dist/client/components/v-icon-button.js 523 B 0 B
./frontend/.nuxt/dist/client/components/v-icon-button.modern.js 528 B 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.js 1.95 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 1.94 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-details.js 1.44 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-details.modern.js 1.43 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-grid.js 4.41 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 4.3 kB 0 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 641 B 0 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 650 B 0 B
./frontend/.nuxt/dist/client/components/v-load-more.js 1.18 kB 0 B
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 1.07 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-license.js 930 B 0 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 939 B 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 2.93 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 2.91 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.js 416 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 421 B 0 B
./frontend/.nuxt/dist/client/components/v-modal.js 1 kB 0 B
./frontend/.nuxt/dist/client/components/v-modal.modern.js 996 B 0 B
./frontend/.nuxt/dist/client/components/v-no-results.js 854 B 0 B
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 857 B 0 B
./frontend/.nuxt/dist/client/components/v-radio.js 1 kB 0 B
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.js 824 B 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 744 B 0 B
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.js 4.38 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.modern.js 4.25 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-images.js 806 B 0 B
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 719 B 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 975 B 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 981 B 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.72 kB 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.72 kB 0 B
./frontend/.nuxt/dist/client/components/v-safety-wall.js 1.31 kB 0 B
./frontend/.nuxt/dist/client/components/v-safety-wall.modern.js 1.32 kB 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.js 891 B 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 891 B 0 B
./frontend/.nuxt/dist/client/components/v-search-grid.js 6.82 kB 0 B
./frontend/.nuxt/dist/client/components/v-search-grid.modern.js 6.18 kB 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.js 617 B 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 621 B 0 B
./frontend/.nuxt/dist/client/components/v-server-timeout.js 302 B 0 B
./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js 306 B 0 B
./frontend/.nuxt/dist/client/components/v-single-result-controls.js 1.36 kB 0 B
./frontend/.nuxt/dist/client/components/v-single-result-controls.modern.js 1.36 kB 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 915 B 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.07 kB 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.07 kB 0 B
./frontend/.nuxt/dist/client/components/v-sources-table.js 14.4 kB 0 B
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 14.4 kB 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B 0 B
./frontend/.nuxt/dist/client/pages/about.js 1.42 kB -2 B (0%)
./frontend/.nuxt/dist/client/pages/about.modern.js 1.42 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 10.7 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 10.4 kB 0 B
./frontend/.nuxt/dist/client/pages/feedback.js 1.36 kB 0 B
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.36 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/index.js 8.22 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 8.04 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/report.js 4.89 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.67 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/index.js 6.34 kB 0 B
./frontend/.nuxt/dist/client/pages/index.modern.js 6.3 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/preferences.js 1.32 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.31 kB 0 B
./frontend/.nuxt/dist/client/pages/privacy.js 1.26 kB 0 B
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.26 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/search-help.js 1.62 kB 0 B
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.61 kB 0 B
./frontend/.nuxt/dist/client/pages/search.js 2.27 kB +2 B (0%)
./frontend/.nuxt/dist/client/pages/search.modern.js 2.09 kB 0 B
./frontend/.nuxt/dist/client/pages/search/audio.js 503 B 0 B
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 507 B +1 B (0%)
./frontend/.nuxt/dist/client/pages/search/image.js 461 B +1 B (0%)
./frontend/.nuxt/dist/client/pages/search/image.modern.js 462 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/index.js 315 B 0 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 320 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 242 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 245 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/video.js 239 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/video.modern.js 244 B 0 B
./frontend/.nuxt/dist/client/pages/sources.js 1.54 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.54 kB 0 B
./frontend/.nuxt/dist/client/vendors/app.js 68.3 kB +1 B (0%)
./frontend/.nuxt/dist/client/vendors/app.modern.js 68.1 kB 0 B

compressed-size-action

@github-actions
Copy link

Full-stack documentation: https://docs.openverse.org/_preview/2827

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@obulat obulat merged commit 4ec5b3e into main Aug 14, 2023
@obulat obulat deleted the update/remove-tcv-docs-link branch August 14, 2023 07:10
@obulat obulat mentioned this pull request Sep 19, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obulat obulat obulat approved these changes

@dhruvkb dhruvkb Awaiting requested review from dhruvkb dhruvkb is a code owner automatically assigned from WordPress/openverse-frontend

Assignees
No one assigned
Labels
📄 aspect: text Concerns the textual material in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarayourfriend @obulat