Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VImageCell storybook test #2821

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Fix VImageCell storybook test #2821

merged 3 commits into from
Aug 14, 2023

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Aug 13, 2023

Fixes

Fixes #2820 by @obulat

Description

The storybook test was making the network requests to render image in the image cell. Sometimes this request failed in the CI, which failed the CI tests. To prevent this, this PR uses a base64-encoded version of the image as the image URL for storybook VImageCell story. This ensures that the image is always loaded and rendered correctly.

Testing Instructions

The CI should pass.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@github-actions github-actions bot added 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend labels Aug 13, 2023
@openverse-bot openverse-bot added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Aug 13, 2023
@github-actions
Copy link

github-actions bot commented Aug 13, 2023 •
edited
Loading

Size Change: 0 B

Total Size: 868 kB

ℹ️ View Unchanged
Filename Size
./frontend/.nuxt/dist/client/238.js 273 B
./frontend/.nuxt/dist/client/238.modern.js 277 B
./frontend/.nuxt/dist/client/239.js 1.85 kB
./frontend/.nuxt/dist/client/app.js 122 kB
./frontend/.nuxt/dist/client/app.modern.js 113 kB
./frontend/.nuxt/dist/client/commons/app.js 90.2 kB
./frontend/.nuxt/dist/client/commons/app.modern.js 80.8 kB
./frontend/.nuxt/dist/client/commons/components/v-search-grid/pages/search.js 5.17 kB
./frontend/.nuxt/dist/client/commons/components/v-search-grid/pages/search.modern.js 5.61 kB
./frontend/.nuxt/dist/client/components/loading-icon.js 729 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 733 B
./frontend/.nuxt/dist/client/components/table-sort-icon.js 514 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 518 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 6.62 kB
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 6.46 kB
./frontend/.nuxt/dist/client/components/v-audio-collection.js 4.38 kB
./frontend/.nuxt/dist/client/components/v-audio-collection.modern.js 4.26 kB
./frontend/.nuxt/dist/client/components/v-audio-details.js 1.79 kB
./frontend/.nuxt/dist/client/components/v-audio-details.modern.js 1.77 kB
./frontend/.nuxt/dist/client/components/v-audio-list.js 1.33 kB
./frontend/.nuxt/dist/client/components/v-audio-list.modern.js 1.31 kB
./frontend/.nuxt/dist/client/components/v-audio-result.js 1 kB
./frontend/.nuxt/dist/client/components/v-audio-result.modern.js 995 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 960 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 961 B
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.67 kB
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.63 kB
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 634 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 640 B
./frontend/.nuxt/dist/client/components/v-bone.js 632 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 636 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.33 kB
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.33 kB
./frontend/.nuxt/dist/client/components/v-content-link.js 1.06 kB
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.06 kB
./frontend/.nuxt/dist/client/components/v-content-page.js 531 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 535 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 493 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 497 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.33 kB
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.21 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 3.8 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 3.67 kB
./frontend/.nuxt/dist/client/components/v-copy-button.js 3.99 kB
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4 kB
./frontend/.nuxt/dist/client/components/v-copy-license.js 2.27 kB
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 2.25 kB
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 792 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 797 B
./frontend/.nuxt/dist/client/components/v-error-image.js 2.41 kB
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 2.38 kB
./frontend/.nuxt/dist/client/components/v-error-section.js 372 B
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 375 B
./frontend/.nuxt/dist/client/components/v-external-search-form.js 2 kB
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 1.98 kB
./frontend/.nuxt/dist/client/components/v-external-source-list.js 896 B
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 896 B
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.57 kB
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.58 kB
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.53 kB
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.53 kB
./frontend/.nuxt/dist/client/components/v-hide-button.js 811 B
./frontend/.nuxt/dist/client/components/v-hide-button.modern.js 813 B
./frontend/.nuxt/dist/client/components/v-home-gallery.js 4.28 kB
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 4.26 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.8 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.77 kB
./frontend/.nuxt/dist/client/components/v-icon-button.js 523 B
./frontend/.nuxt/dist/client/components/v-icon-button.modern.js 527 B
./frontend/.nuxt/dist/client/components/v-image-cell.js 1.95 kB
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 1.94 kB
./frontend/.nuxt/dist/client/components/v-image-details.js 1.44 kB
./frontend/.nuxt/dist/client/components/v-image-details.modern.js 1.43 kB
./frontend/.nuxt/dist/client/components/v-image-grid.js 4.42 kB
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 4.3 kB
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 641 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 649 B
./frontend/.nuxt/dist/client/components/v-load-more.js 1.18 kB
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 1.06 kB
./frontend/.nuxt/dist/client/components/v-media-license.js 932 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 939 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 2.93 kB
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 2.91 kB
./frontend/.nuxt/dist/client/components/v-media-tag.js 416 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 421 B
./frontend/.nuxt/dist/client/components/v-modal.js 1 kB
./frontend/.nuxt/dist/client/components/v-modal.modern.js 996 B
./frontend/.nuxt/dist/client/components/v-no-results.js 855 B
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 857 B
./frontend/.nuxt/dist/client/components/v-radio.js 1 kB
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.01 kB
./frontend/.nuxt/dist/client/components/v-related-audio.js 824 B
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 743 B
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.js 4.38 kB
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.modern.js 4.25 kB
./frontend/.nuxt/dist/client/components/v-related-images.js 806 B
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 719 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 976 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 981 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.72 kB
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.73 kB
./frontend/.nuxt/dist/client/components/v-safety-wall.js 1.31 kB
./frontend/.nuxt/dist/client/components/v-safety-wall.modern.js 1.32 kB
./frontend/.nuxt/dist/client/components/v-scroll-button.js 891 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 891 B
./frontend/.nuxt/dist/client/components/v-search-grid.js 6.83 kB
./frontend/.nuxt/dist/client/components/v-search-grid.modern.js 6.18 kB
./frontend/.nuxt/dist/client/components/v-search-results-title.js 618 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 620 B
./frontend/.nuxt/dist/client/components/v-server-timeout.js 302 B
./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js 306 B
./frontend/.nuxt/dist/client/components/v-single-result-controls.js 1.36 kB
./frontend/.nuxt/dist/client/components/v-single-result-controls.modern.js 1.36 kB
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.01 kB
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 915 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.07 kB
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.07 kB
./frontend/.nuxt/dist/client/components/v-sources-table.js 14.4 kB
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 14.4 kB
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 307 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B
./frontend/.nuxt/dist/client/pages/about.js 1.42 kB
./frontend/.nuxt/dist/client/pages/about.modern.js 1.42 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 10.7 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 10.4 kB
./frontend/.nuxt/dist/client/pages/feedback.js 1.36 kB
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.36 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.js 8.22 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 8.04 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.js 4.89 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.67 kB
./frontend/.nuxt/dist/client/pages/index.js 6.34 kB
./frontend/.nuxt/dist/client/pages/index.modern.js 6.3 kB
./frontend/.nuxt/dist/client/pages/preferences.js 1.32 kB
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.31 kB
./frontend/.nuxt/dist/client/pages/privacy.js 1.26 kB
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.26 kB
./frontend/.nuxt/dist/client/pages/search-help.js 1.62 kB
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.61 kB
./frontend/.nuxt/dist/client/pages/search.js 2.27 kB
./frontend/.nuxt/dist/client/pages/search.modern.js 2.09 kB
./frontend/.nuxt/dist/client/pages/search/audio.js 503 B
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 506 B
./frontend/.nuxt/dist/client/pages/search/image.js 461 B
./frontend/.nuxt/dist/client/pages/search/image.modern.js 463 B
./frontend/.nuxt/dist/client/pages/search/index.js 313 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 320 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 242 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 246 B
./frontend/.nuxt/dist/client/pages/search/video.js 240 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 244 B
./frontend/.nuxt/dist/client/pages/sources.js 1.54 kB
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.54 kB
./frontend/.nuxt/dist/client/runtime.js 2.75 kB
./frontend/.nuxt/dist/client/runtime.modern.js 2.75 kB
./frontend/.nuxt/dist/client/vendors/app.js 68.3 kB
./frontend/.nuxt/dist/client/vendors/app.modern.js 68.1 kB

compressed-size-action

@obulat obulat force-pushed the fix/skip-flaky-test branch from 472935e to 67ddd98 Compare August 14, 2023 01:17
@github-actions
Copy link

Full-stack documentation: https://docs.openverse.org/_preview/2821

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@obulat obulat self-assigned this Aug 14, 2023
@obulat obulat marked this pull request as ready for review August 14, 2023 01:38
@obulat obulat requested a review from a team as a code owner August 14, 2023 01:38
sarayourfriend
sarayourfriend approved these changes Aug 14, 2023
View reviewed changes
frontend/src/components/VImageCell/meta/VImageCell.stories.mdx
Comment on lines 9 to +10
import { image } from "~~/test/unit/fixtures/image"
import { base64Image } from "~~/test/unit/fixtures/base64Image"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@obulat
Copy link
Contributor Author

obulat commented Aug 14, 2023

Merging with 1 approval because it's a critical change that would be nice to merge before deployment.

@obulat obulat merged commit eb05c6b into main Aug 14, 2023
@obulat obulat deleted the fix/skip-flaky-test branch August 14, 2023 06:51
@obulat obulat mentioned this pull request Sep 14, 2023
Merged
8 tasks
@obulat obulat mentioned this pull request Oct 10, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarayourfriend sarayourfriend sarayourfriend approved these changes

@dhruvkb dhruvkb Awaiting requested review from dhruvkb dhruvkb is a code owner automatically assigned from WordPress/openverse-frontend

Assignees

@obulat obulat

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storybook visual-regression/v-image-cell.spec.ts:19:9 › VImageCell › intrinsic loaded test is flaky
3 participants
@obulat @sarayourfriend @openverse-bot