Update source links on single results page #2735

obulat · 2023-07-27T08:03:55Z

Fixes

Fixes #2731 by @obulat
Related to #2582 by @fcoveram

Description

This PR implements only part of #2582: makes the links stack vertically, and adds the external link icon. It does not add the information tooltip.

Testing Instructions

Checklist

My pull request has a descriptive title (not a vague title likeUpdate index.md).
My pull request targets the default branch of the repository (main) or a parent feature branch.
My commit messages follow best practices.
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no visible errors.
I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

github-actions · 2023-07-27T08:10:15Z

Size Change: +1.88 kB (0%)

Total Size: 870 kB

Filename	Size	Change
`./frontend/.nuxt/dist/client/238.js`	0 B	-272 B (removed)	🏆
`./frontend/.nuxt/dist/client/238.modern.js`	0 B	-277 B (removed)	🏆
`./frontend/.nuxt/dist/client/239.js`	273 B	-1.58 kB (-85%)	🏆
`./frontend/.nuxt/dist/client/app.js`	123 kB	+346 B (0%)
`./frontend/.nuxt/dist/client/app.modern.js`	114 kB	+291 B (0%)
`./frontend/.nuxt/dist/client/commons/app.js`	90.5 kB	+16 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-collection.modern.js`	4.27 kB	+14 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-details.js`	0 B	-1.79 kB (removed)	🏆
`./frontend/.nuxt/dist/client/components/v-audio-details.modern.js`	0 B	-1.77 kB (removed)	🏆
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js`	1.54 kB	+10 B (+1%)
`./frontend/.nuxt/dist/client/components/v-image-details.js`	0 B	-1.44 kB (removed)	🏆
`./frontend/.nuxt/dist/client/components/v-image-details.modern.js`	0 B	-1.43 kB (removed)	🏆
`./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.js`	0 B	-4.38 kB (removed)	🏆
`./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.modern.js`	0 B	-4.25 kB (removed)	🏆
`./frontend/.nuxt/dist/client/components/v-sources-table.js`	14.5 kB	+130 B (+1%)
`./frontend/.nuxt/dist/client/components/v-sources-table.modern.js`	14.5 kB	+131 B (+1%)
`./frontend/.nuxt/dist/client/pages/audio/_id/index.js`	10.4 kB	-279 B (-3%)
`./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js`	10.2 kB	-258 B (-2%)
`./frontend/.nuxt/dist/client/pages/image/_id/index.js`	9.01 kB	+793 B (+10%)	⚠️
`./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js`	8.82 kB	+789 B (+10%)	⚠️
`./frontend/.nuxt/dist/client/239.modern.js`	277 B	+277 B (new file)	🆕
`./frontend/.nuxt/dist/client/240.js`	1.85 kB	+1.85 kB (new file)	🆕
`./frontend/.nuxt/dist/client/components/v-media-details.js`	2.26 kB	+2.26 kB (new file)	🆕
`./frontend/.nuxt/dist/client/components/v-media-details.modern.js`	2.23 kB	+2.23 kB (new file)	🆕
`./frontend/.nuxt/dist/client/components/v-media-details/pages/image/_id/index.js`	3.79 kB	+3.79 kB (new file)	🆕
`./frontend/.nuxt/dist/client/components/v-media-details/pages/image/_id/index.modern.js`	3.67 kB	+3.67 kB (new file)	🆕
`./frontend/.nuxt/dist/client/components/v-media-tags.js`	644 B	+644 B (new file)	🆕
`./frontend/.nuxt/dist/client/components/v-media-tags.modern.js`	632 B	+632 B (new file)	🆕
`./frontend/.nuxt/dist/client/components/v-metadata.js`	834 B	+834 B (new file)	🆕
`./frontend/.nuxt/dist/client/components/v-metadata.modern.js`	843 B	+843 B (new file)	🆕

ℹ️ View Unchanged

Filename	Size	Change
`./frontend/.nuxt/dist/client/commons/app.modern.js`	81.1 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/commons/components/v-search-grid/pages/search.js`	5.17 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/commons/components/v-search-grid/pages/search.modern.js`	5.61 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/components/loading-icon.js`	728 B	0 B
`./frontend/.nuxt/dist/client/components/loading-icon.modern.js`	733 B	0 B
`./frontend/.nuxt/dist/client/components/table-sort-icon.js`	514 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js`	519 B	0 B
`./frontend/.nuxt/dist/client/components/v-all-results-grid.js`	6.61 kB	0 B
`./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js`	6.46 kB	+3 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-collection.js`	4.39 kB	+8 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-list.js`	1.32 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-list.modern.js`	1.31 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-result.js`	1 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-result.modern.js`	995 B	0 B
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js`	958 B	0 B
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js`	961 B	0 B
`./frontend/.nuxt/dist/client/components/v-audio-track.js`	5.68 kB	+3 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-track.modern.js`	5.64 kB	+4 B (0%)
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js`	633 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js`	640 B	0 B
`./frontend/.nuxt/dist/client/components/v-bone.js`	632 B	0 B
`./frontend/.nuxt/dist/client/components/v-bone.modern.js`	636 B	0 B
`./frontend/.nuxt/dist/client/components/v-box-layout.js`	1.33 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-box-layout.modern.js`	1.33 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-link.js`	1.06 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-link.modern.js`	1.06 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-page.js`	530 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-page.modern.js`	535 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.js`	492 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js`	497 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-form.js`	3.33 kB	+3 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js`	3.21 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-report-popover.js`	3.79 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js`	3.67 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/components/v-copy-button.js`	3.99 kB	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-copy-button.modern.js`	4 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/components/v-copy-license.js`	2.27 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-copy-license.modern.js`	2.25 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-dmca-notice.js`	792 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js`	798 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-error-image.js`	2.41 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-error-image.modern.js`	2.38 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/components/v-error-section.js`	372 B	0 B
`./frontend/.nuxt/dist/client/components/v-error-section.modern.js`	377 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-external-search-form.js`	2 kB	0 B
`./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js`	1.98 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-external-source-list.js`	896 B	0 B
`./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js`	896 B	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-full-layout.js`	1.57 kB	+4 B (0%)
`./frontend/.nuxt/dist/client/components/v-full-layout.modern.js`	1.58 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.js`	1.53 kB	+9 B (+1%)
`./frontend/.nuxt/dist/client/components/v-hide-button.js`	812 B	0 B
`./frontend/.nuxt/dist/client/components/v-hide-button.modern.js`	813 B	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-home-gallery.js`	4.28 kB	0 B
`./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js`	4.26 kB	0 B
`./frontend/.nuxt/dist/client/components/v-homepage-content.js`	1.8 kB	0 B
`./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js`	1.77 kB	0 B
`./frontend/.nuxt/dist/client/components/v-icon-button.js`	523 B	0 B
`./frontend/.nuxt/dist/client/components/v-icon-button.modern.js`	527 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-image-cell.js`	1.95 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-image-cell.modern.js`	1.94 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-grid.js`	4.42 kB	+5 B (0%)
`./frontend/.nuxt/dist/client/components/v-image-grid.modern.js`	4.3 kB	+4 B (0%)
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.js`	640 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js`	649 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-load-more.js`	1.17 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-load-more.modern.js`	1.06 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/components/v-media-license.js`	931 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-media-license.modern.js`	940 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-media-reuse.js`	2.93 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js`	2.91 kB	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-media-tag.js`	416 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-tag.modern.js`	419 B	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-modal.js`	1.01 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-modal.modern.js`	996 B	0 B
`./frontend/.nuxt/dist/client/components/v-no-results.js`	855 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-no-results.modern.js`	858 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-radio.js`	1 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-radio.modern.js`	1.01 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/components/v-related-audio.js`	824 B	0 B
`./frontend/.nuxt/dist/client/components/v-related-audio.modern.js`	744 B	0 B
`./frontend/.nuxt/dist/client/components/v-related-images.js`	804 B	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-related-images.modern.js`	718 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-report-desc-form.js`	976 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js`	981 B	0 B
`./frontend/.nuxt/dist/client/components/v-row-layout.js`	1.72 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-row-layout.modern.js`	1.72 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-safety-wall.js`	1.32 kB	+9 B (+1%)
`./frontend/.nuxt/dist/client/components/v-safety-wall.modern.js`	1.33 kB	+5 B (0%)
`./frontend/.nuxt/dist/client/components/v-scroll-button.js`	891 B	0 B
`./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js`	891 B	0 B
`./frontend/.nuxt/dist/client/components/v-search-grid.js`	6.82 kB	-4 B (0%)
`./frontend/.nuxt/dist/client/components/v-search-grid.modern.js`	6.18 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-search-results-title.js`	617 B	0 B
`./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js`	622 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-server-timeout.js`	302 B	0 B
`./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js`	307 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-single-result-controls.js`	1.35 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-single-result-controls.modern.js`	1.36 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js`	1.01 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js`	915 B	0 B
`./frontend/.nuxt/dist/client/components/v-snackbar.js`	1.07 kB	0 B
`./frontend/.nuxt/dist/client/components/v-snackbar.modern.js`	1.07 kB	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.js`	307 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js`	311 B	0 B
`./frontend/.nuxt/dist/client/pages/about.js`	1.42 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/about.modern.js`	1.42 kB	0 B
`./frontend/.nuxt/dist/client/pages/feedback.js`	1.36 kB	0 B
`./frontend/.nuxt/dist/client/pages/feedback.modern.js`	1.36 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/pages/image/_id/report.js`	4.89 kB	+5 B (0%)
`./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js`	4.67 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/index.js`	6.33 kB	-2 B (0%)
`./frontend/.nuxt/dist/client/pages/index.modern.js`	6.3 kB	+3 B (0%)
`./frontend/.nuxt/dist/client/pages/preferences.js`	1.32 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/preferences.modern.js`	1.31 kB	0 B
`./frontend/.nuxt/dist/client/pages/privacy.js`	1.26 kB	0 B
`./frontend/.nuxt/dist/client/pages/privacy.modern.js`	1.26 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search-help.js`	1.62 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search-help.modern.js`	1.61 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search.js`	2.27 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search.modern.js`	2.09 kB	0 B
`./frontend/.nuxt/dist/client/pages/search/audio.js`	503 B	0 B
`./frontend/.nuxt/dist/client/pages/search/audio.modern.js`	506 B	0 B
`./frontend/.nuxt/dist/client/pages/search/image.js`	461 B	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/image.modern.js`	462 B	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/index.js`	316 B	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/index.modern.js`	320 B	0 B
`./frontend/.nuxt/dist/client/pages/search/model-3d.js`	243 B	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js`	246 B	0 B
`./frontend/.nuxt/dist/client/pages/search/video.js`	240 B	0 B
`./frontend/.nuxt/dist/client/pages/search/video.modern.js`	243 B	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/sources.js`	1.53 kB	0 B
`./frontend/.nuxt/dist/client/pages/sources.modern.js`	1.54 kB	0 B
`./frontend/.nuxt/dist/client/runtime.js`	2.76 kB	+6 B (0%)
`./frontend/.nuxt/dist/client/runtime.modern.js`	2.76 kB	+6 B (0%)
`./frontend/.nuxt/dist/client/vendors/app.js`	68.3 kB	0 B
`./frontend/.nuxt/dist/client/vendors/app.modern.js`	68.1 kB	+1 B (0%)

_{compressed-size-action}

obulat · 2023-08-22T04:29:50Z

Closing in favor of #2851.

github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label Jul 27, 2023

openverse-bot added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software labels Jul 27, 2023

obulat self-assigned this Jul 27, 2023

obulat force-pushed the update_source_links branch 6 times, most recently from aecf965 to 9721421 Compare July 29, 2023 08:53

This was referenced Jul 29, 2023

Audio instructions snackbar is not hidden when you navigate from All results to single result page #2742

Closed

Fix audio snackbar and box audio seeking #2743

Merged

obulat changed the base branch from main to fix/snackbar_show_on_mouse_focus July 29, 2023 10:45

obulat force-pushed the fix/snackbar_show_on_mouse_focus branch from 8556807 to a8f3747 Compare July 29, 2023 11:11

obulat force-pushed the update_source_links branch 2 times, most recently from cdf676e to 6393ecd Compare July 29, 2023 11:43

obulat added this to the Creator, Tag, and Source frontend views milestone Jul 29, 2023

obulat force-pushed the fix/snackbar_show_on_mouse_focus branch 2 times, most recently from 03415c9 to d56de98 Compare August 9, 2023 08:40

obulat force-pushed the fix/snackbar_show_on_mouse_focus branch from d56de98 to 10a7079 Compare August 9, 2023 20:57

Base automatically changed from fix/snackbar_show_on_mouse_focus to main August 12, 2023 05:30

obulat force-pushed the update_source_links branch 4 times, most recently from 3943752 to 9c06ef3 Compare August 14, 2023 15:43

obulat added 3 commits August 15, 2023 05:59

Add external link icon to source links

a15d281

Update snapshots

ca913de

Make the mobile metadata display horizontally

b99f484

obulat added 13 commits August 15, 2023 05:59

Extract VMetadata and VMediaTags components

4e75995

Extract metadata object creation to utils

39b6e7a

Add frontendMediaType to fixtures

a8610f8

Fix media type capitalization

60b22c6

Update snapshots

dda6124

Set metadata title flex basis

aebf32a

Update i18n strings and external links

c1ebff7

Update gap

07c1ea0

Move styles to the template

33edf70

Update snapshots

bcf4b3d

Extract VMediaDetails

9c6a01e

Update snapshots

aad0961

Fix unit test

8812c0c

obulat force-pushed the update_source_links branch from e5f07b7 to 8812c0c Compare August 15, 2023 03:00

obulat closed this Aug 22, 2023

obulat deleted the update_source_links branch September 4, 2023 17:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update source links on single results page #2735

Update source links on single results page #2735

obulat commented Jul 27, 2023 •

edited

Loading

github-actions bot commented Jul 27, 2023 •

edited

Loading

obulat commented Aug 22, 2023

Update source links on single results page #2735

Update source links on single results page #2735

Conversation

obulat commented Jul 27, 2023 • edited Loading

Fixes

Description

Testing Instructions

Checklist

Developer Certificate of Origin

github-actions bot commented Jul 27, 2023 • edited Loading

obulat commented Aug 22, 2023

obulat commented Jul 27, 2023 •

edited

Loading

github-actions bot commented Jul 27, 2023 •

edited

Loading