Rename mature to includeSensitiveResults
#2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧱 stack: documentation
obulat
force-pushed
the
rename_mature_query_param
branch
from
4c7516b to
396309a
Compare
openverse-bot
added
🟨 priority: medium
|
Size Change: +314 B (0%) Total Size: 871 kB
ℹ️ View Unchanged
|
|
Full-stack documentation: https://docs.openverse.org/_preview/2721 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
obulat
force-pushed
the
rename_mature_query_param
branch
from
396309a to
c84ce9a
Compare
| */ | ||
| const filterToString = (filterItem: FilterItem[]) => { | ||
| const filterString = filterItem | ||
| .filter((f) => f.checked) | ||
| .map((filterItem) => filterItem.code) | ||
| .join(",") | ||
| return filterString === "mature" ? "true" : filterString | ||
| // TODO: check this |
There was a problem hiding this comment.
Should this still be checked? 🙂
There was a problem hiding this comment.
Nope :D Removed the comment.
| includeSensitiveResults: [ | ||
| { | ||
| code: "includeSensitiveResults", | ||
| name: "filters.mature.mature", |
There was a problem hiding this comment.
Does this name need to change as well?
There was a problem hiding this comment.
Since this PR does not change the string, it's better not to rename this key, too. Otherwise, we will make this string "fuzzy" in GlotPress - which is not really necessary just yet.
dhruvkb
reviewed
Aug 1, 2023
| @@ -31,7 +32,7 @@ export const NoResultsTemplate = (args) => ({ | |||
| <template #image> | |||
| <VErrorImage :error-code="args.errorCode" /> | |||
| </template> | |||
| <VNoResults :type="args.type" :query="args.query"/> | |||
| <VNoResults :media-type="args.type" :query="args.query" :search-term="args.query.q" :external-sources=[] /> | |||
There was a problem hiding this comment.
VNoResults doesn't take query as a prop.
obulat
force-pushed
the
rename_mature_query_param
branch
from
473ec94 to
59c36a0
Compare
zackkrida
reviewed
Aug 2, 2023
Co-authored-by: Zack Krida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2548 by @dhruvkb
Description
The
maturequery parameter is renamed tounstable__include_sensitive_results.The filter category is renamed from
maturetoincludeSensitiveResultsThe filter object in the search store is changed from
mature: { code: "mature", name: "...", checked: true }toincludeSensitiveResults: { code: "includeSensitiveResults", name: "", checked: true }.Testing Instructions
We have extensive unit tests for transforming the query to filters in the
searchstore, and filters to the API query parameters. They should pass.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin