Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update back to results button area #2696

Merged

Conversation

nevvada
Copy link
Contributor

@nevvada nevvada commented Jul 21, 2023

Fixes

Fixes #2657 by @fcoveram

Description

this PR:

  • updates padding around "Back to results" button area, per figma designs

Image page
image
image

Audio page
image
image

⚠️ this PR does not: ⚠️

  • update the styling of the buttons as mentioned in the original issue description. the buttons in prod already match the expected changes. please see this comment for more information

Testing Instructions

  • navigate to an image or audio page from the search results. verify that the padding updates reflects the Figma design in viewport below and above the medium breakpoint (768px)

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@nevvada nevvada requested a review from a team as a code owner July 21, 2023 17:49
@nevvada nevvada requested review from obulat and dhruvkb July 21, 2023 17:49
@openverse-bot openverse-bot added 🟧 priority: high Stalls work on the project or its dependents 🏁 status: ready for work Ready for work ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🧱 stack: frontend Related to the Nuxt frontend labels Jul 21, 2023
@obulat obulat requested a review from fcoveram July 21, 2023 18:45
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense @nevvada, thank you for your contribution!
@fcoveram could add a clarification regarding the padding values and the thresholds from which they should change.

frontend/src/pages/audio/_id/index.vue Show resolved Hide resolved
@obulat obulat removed the 🏁 status: ready for work Ready for work label Jul 21, 2023
@zackkrida
Copy link
Member

Hi @nevvada! I actually have the button size change, from medium to small, present in another PR I'm working on:

The PR: #2651
The specific change:

I'll merge this PR as-is, and we'd love more contributions from you in the future! Thanks for getting this padding adjustment fixed so quickly 😄

@zackkrida zackkrida merged commit fc6006d into WordPress:main Jul 25, 2023
@nevvada
Copy link
Contributor Author

nevvada commented Jul 25, 2023

@zackkrida ohh gotcha, i mistook the text, not the button size that had to be changed to small.

cool, thanks for addressing in your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update "Back to results" and "Report this content" buttons
5 participants