Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat 403s from Europeana as dead links #2425

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

krysal
Copy link
Member

@krysal krysal commented Jun 16, 2023

Fixes

Fixes #2417 by @krysal

Description

Adds the exception for Europeana as said in the issue.

Testing Instructions

  1. To manually test these changes, copy this row to the sample_data/sample_image.csv file
27d7186f-2f8e-4d24-badd-d6e4bdc60071,2022-11-27 14:37:37.668997+00,2022-11-27 14:37:37.668997+00,provider_api,europeana,europeana,/2022709/oai_fototeca_mcu_es_fototeca_MORENO_04766_C,https://www.mcu.es/fototeca_patrimonio/show_ficha.do?archivo=MORENO&record=04766_C,https://www.mcu.es/fototeca_patrimonio/Visor?usarVisorMCU=false&archivo=MORENO/preview/04766_C_P.jpg,,,,,by-nc-nd,4.0,,,Arco de flechas,"{""license_url"": ""https://creativecommons.org/licenses/by-nc-nd/4.0/"", ""raw_license_url"": null}",,f,2022-11-27 14:37:37.668997+00,f,jpg,,
  1. Confirm you have the environment variable FILTER_DEAD_LINKS_BY_DEFAULT set to True you don't have it set to anything (it's true by default)
  2. Run just api/recreate
  3. Confirm the following search returns zero result http://localhost:50280/v1/images/?source=europeana

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • [N/A] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal requested a review from a team as a code owner June 16, 2023 16:22
@krysal krysal requested review from obulat and dhruvkb June 16, 2023 16:22
@github-actions github-actions bot added the 🧱 stack: api Related to the Django API label Jun 16, 2023
@openverse-bot openverse-bot added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Jun 16, 2023
api/env.docker Show resolved Hide resolved
Copy link
Collaborator

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krysal krysal merged commit 5d5f406 into main Jun 19, 2023
@krysal krysal deleted the fix/europeana_dead_at_403 branch June 19, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Treat a 403 response code from Europeana as dead link
4 participants