-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix API image builds #2410
Fix API image builds #2410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the image builds locally and that it generates audio waveforms correctly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. I'll create an issue to move this out after resolving the critical issue.
python manage.py collectstatic | ||
SETUP_ES="False" \ | ||
STATIC_ROOT="/static" \ | ||
DJANGO_SECRET_KEY="any string" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering why this is needed here 😶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, all works locally 💯
Fixes
Fixes #2411 by @zackkrida
Description
Fixes the conflict when copying over audiowaveform dependencies from the Dockerfile by explicitly copying over subfolder contents instead of the subfolders themselves, which already exist as symlinks in the root of the base image and therefore cause an error when attempting to copy over them.
Testing Instructions
Review the code, CI should pass. After merged, the staging API should continue to work and serve thumbnails.
You can also checkout
main
andjust recreate
. Observe that the build fails. Then checkout this branch andjust recreate && just up
and observe that everything works.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin