Check filtered index feature flag before querying in SearchContext

[sarayourfriend]

Fixes

Fixes #2407 by @sarayourfriend

Description

Checks the feature flag before querying the filtered index.

Testing Instructions

First, confirm you know how to reproduce the issue on main. Checkout main and update api/env to set ENABLE_FILTERED_INDEX_QUERIES=False to match the live environment configuration. Next, delete the image-filtered alias in your local Elasticsearch cluster:

$ curl -X DELETE http://0.0.0.0:50292/image-init-filtered/_alias/image-filtered

Confirm the index is deleted by sending:

$ curl http://0.0.0.0:50292/image-init-filtered/_alias

And confirm the response matches (empty aliases object):

{"image-init-filtered":{"aliases":{}}}

Now make a request to http://localhost:50280/v1/images/ and confirm you get a 500 about image-filtered not existing.

Now, check out this branch and just down && just api/up and make the same http://localhost:50280/v1/images/ request again, and you should no longer have the 500, just a successful image search.

Confirm the additional unit test sufficiently covers the changes.

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• [N/A] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[obulat]

Tested well locally, and the changes make sense.

[zackkrida]

Phenomenal test instructions. Was able to reproduce the issue on main easily and the PR fixed the problem as described.

❯ curl -X DELETE http://0.0.0.0:50292/image-init-filtered/_alias/image-filtered
{"acknowledged":true}%

❯ curl http://0.0.0.0:50292/image-init-filtered/_alias
{"image-init-filtered":{"aliases":{}}}%

and then: