-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy staging API after staging DB restore #2211
Conversation
27cae2b
to
2c00b15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, tested and was able to kick off the staging deploy, which failed as expected: https://github.com/WordPress/openverse-infrastructure/actions/runs/5147523267
🎉
catalog/dags/database/staging_database_restore/staging_database_restore.py
Outdated
Show resolved
Hide resolved
Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR: @krysal Excluding weekend1 days, this PR was ready for review 5 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2. @AetherUnbound, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
So in order to test this, from
then from
and from here:
(easy-peasy? lol...) I'll try now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
catalog/tests/dags/database/staging_database_restore/test_staging_database_restore.py
Show resolved
Hide resolved
This is definitely one of the most cross-system DAGs we have... 😅 Thanks for taking the time to test everything @krysal! |
Co-authored-by: Staci Mullins <63313398+stacimc@users.noreply.github.com>
ee90144
to
9e3b33b
Compare
Fixes
Another step towards completing #1989, builds off of #2207
Description
This PR adds a step to the staging database restore DAG which pulls the most recent API package version and dispatches the staging API deployment workflow with that version. While the deployment workflow itself needs a follow-up update to allow the
openverse-bot
to run deployments, this does correctly trigger the deployment workflow! Example: https://github.com/WordPress/openverse-infrastructure/actions/runs/5096003624I added a similar mechanism for setting up the GitHubAPI as we had for the RdsHook, it seemed easiest for the two functions we were using it in. I also changed the flow a little to only report completion after the truncate & deployment steps were complete, rather than alongside.
Testing Instructions
To test this, follow the instructions in #2099 and #2207. Make sure you have the
GITHUB_API_KEY
Airflow Variable defined as well with our team PAT. When the DAG gets to these steps, it should appropriately kick off the staging API deployment (although it will fail until we make the appropriate adjustments to it).Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin