Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script to generate the media_properties.md #2205

Closed
wants to merge 3 commits into from

Conversation

obulat
Copy link
Contributor

@obulat obulat commented May 26, 2023

Fixes

Fixes #2186 by @obulat

Description

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@github-actions github-actions bot added 🧱 stack: catalog Related to the catalog and Airflow DAGs 🧱 stack: documentation Related to Sphinx documentation labels May 26, 2023
@openverse-bot openverse-bot added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels May 26, 2023
@obulat obulat force-pushed the add/media_properties_generation branch from 4d3a0cf to 51b8c32 Compare May 26, 2023 15:15
@github-actions
Copy link

github-actions bot commented May 26, 2023

Full-stack documentation: https://docs.openverse.org/_preview/2205

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

New files ➕:

Changed files 🔄:

@obulat obulat self-assigned this May 29, 2023
@obulat
Copy link
Contributor Author

obulat commented May 29, 2023

Based on the SQL requests results in #244 and the table in this PR preview, there are some inconsistencies.

Data inconsistencies

Nullable columns

The database fields that are nullable in DDLs but don't have any NULL values in the database

  • identifier
  • ingestion_type
  • provider (there is an index on it, in combination with `foreign_identifier)
  • source
  • foreign_identifier (there is an index on it, in combination with provider)
  • foreign_landing_url
  • license (no data in the linked issue, but there should be no row without a license)
  • license_version

@obulat obulat force-pushed the add/media_properties_generation branch 2 times, most recently from f67acce to c923885 Compare May 29, 2023 12:41
@obulat obulat force-pushed the add/media_properties_generation branch 2 times, most recently from ef5f27b to cf25053 Compare June 13, 2023 03:59
@sarayourfriend
Copy link
Collaborator

@obulat What is the status of this PR? Is it still being worked on or is it blocked? Do you need help with anything to get it ready for review or would pairing with someone help?

@obulat obulat force-pushed the add/media_properties_generation branch from cf25053 to 420e660 Compare July 12, 2023 06:33
@obulat obulat force-pushed the add/media_properties_generation branch from 420e660 to c99aa8a Compare August 21, 2023 08:07
@obulat
Copy link
Contributor Author

obulat commented Aug 28, 2023

This PR is drafted until the Additional search views project is finished.

@obulat obulat force-pushed the add/media_properties_generation branch from c99aa8a to cf7bd3c Compare September 11, 2023 12:22
@obulat
Copy link
Contributor Author

obulat commented Sep 11, 2023

Closing this PR for now, will reopen when this project is restarted.

@obulat obulat closed this Sep 11, 2023
@obulat obulat deleted the add/media_properties_generation branch May 7, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs 🧱 stack: documentation Related to Sphinx documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create a script to automatically generate media properties
3 participants