Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update External link buttons on No results page #2114

Merged
merged 2 commits into from
May 19, 2023
Merged

Update External link buttons on No results page #2114

merged 2 commits into from
May 19, 2023

Conversation

obulat
Copy link
Contributor

@obulat obulat commented May 16, 2023 •
edited
Loading

Fixes

Related to #1187 by @obulat

Description

This PR updates the external sources links buttons to a new variant and medium size.
The Figma file for these buttons is being updated, but we confirmed with @fcoveram that the buttons should use bordered-gray variant, medium size and have a 16px gap between them.

Testing Instructions

Search for "non-existent-query" and see the "No results" page. Check that the buttons look correct and the CI passes.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@github-actions github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label May 16, 2023
@obulat obulat added 🕹 aspect: interface Concerns end-users' experience with the software 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature labels May 16, 2023
@github-actions
Copy link

github-actions bot commented May 16, 2023 •
edited
Loading

Size Change: -90 B (0%)

Total Size: 832 kB

Filename Size Change
./frontend/.nuxt/dist/client/app.js 126 kB -18 B (0%)
./frontend/.nuxt/dist/client/app.modern.js 117 kB -20 B (0%)
./frontend/.nuxt/dist/client/components/v-sources-table.js 15.2 kB -21 B (0%)
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 15.2 kB -21 B (0%)
ℹ️ View Unchanged
Filename Size Change
./frontend/.nuxt/dist/client/233.js 272 B 0 B
./frontend/.nuxt/dist/client/233.modern.js 277 B 0 B
./frontend/.nuxt/dist/client/234.js 1.85 kB 0 B
./frontend/.nuxt/dist/client/commons/app.js 90.4 kB 0 B
./frontend/.nuxt/dist/client/commons/app.modern.js 78.5 kB 0 B
./frontend/.nuxt/dist/client/components/loading-icon.js 766 B 0 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 769 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.js 514 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 519 B 0 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 5.75 kB 0 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 5.62 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-cell.js 392 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js 396 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-details.js 2.35 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-details.modern.js 1.77 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.02 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.26 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.21 kB 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 636 B 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 642 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.js 688 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 692 B 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.28 kB 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.27 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-link.js 1.04 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.04 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-page.js 524 B 0 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 528 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 493 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 497 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.86 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.69 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 913 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 4.15 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-button.js 4 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.js 2.09 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 2.06 kB 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 791 B 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 799 B 0 B
./frontend/.nuxt/dist/client/components/v-error-image.js 2.6 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 2.57 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-section.js 372 B 0 B
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 375 B 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.js 1.88 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 1.87 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.js 893 B 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 896 B 0 B
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.56 kB 0 B
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.55 kB 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.61 kB 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.62 kB 0 B
./frontend/.nuxt/dist/client/components/v-home-gallery.js 4.92 kB 0 B
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 4.9 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.77 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.74 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-carousel.js 4.74 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-carousel.modern.js 4.7 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.js 1.68 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 1.67 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-details.js 1.96 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-details.modern.js 1.41 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-grid.js 3.91 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 3.79 kB 0 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 641 B 0 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 649 B 0 B
./frontend/.nuxt/dist/client/components/v-load-more.js 844 B 0 B
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 741 B 0 B
./frontend/.nuxt/dist/client/components/v-media-license.js 828 B 0 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 836 B 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 2.69 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 2.65 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.js 416 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 421 B 0 B
./frontend/.nuxt/dist/client/components/v-modal.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-modal.modern.js 995 B 0 B
./frontend/.nuxt/dist/client/components/v-no-results.js 814 B -7 B (-1%)
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 816 B -9 B (-1%)
./frontend/.nuxt/dist/client/components/v-radio.js 1.54 kB 0 B
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.5 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.js 1.29 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 1.29 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-images.js 1.1 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 1.1 kB 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 977 B 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 979 B 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.68 kB 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.68 kB 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.js 824 B 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 829 B 0 B
./frontend/.nuxt/dist/client/components/v-search-grid.js 6.55 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-search-grid.modern.js 6.47 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-search-results-title.js 618 B 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 622 B 0 B
./frontend/.nuxt/dist/client/components/v-server-timeout.js 299 B 0 B
./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js 303 B 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 912 B 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.16 kB 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.17 kB 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B 0 B
./frontend/.nuxt/dist/client/pages/about.js 1.39 kB 0 B
./frontend/.nuxt/dist/client/pages/about.modern.js 1.4 kB 0 B
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 6.52 kB 0 B
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 5.9 kB 0 B
./frontend/.nuxt/dist/client/pages/external-sources.js 1.55 kB 0 B
./frontend/.nuxt/dist/client/pages/external-sources.modern.js 1.56 kB 0 B
./frontend/.nuxt/dist/client/pages/feedback.js 1.34 kB 0 B
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.34 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/index.js 7.46 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 6.77 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/report.js 2.23 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 5.21 kB 0 B
./frontend/.nuxt/dist/client/pages/index.js 7.04 kB 0 B
./frontend/.nuxt/dist/client/pages/index.modern.js 6.96 kB 0 B
./frontend/.nuxt/dist/client/pages/preferences.js 1.32 kB 0 B
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.32 kB 0 B
./frontend/.nuxt/dist/client/pages/privacy.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.02 kB 0 B
./frontend/.nuxt/dist/client/pages/search-help.js 1.59 kB 0 B
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.58 kB 0 B
./frontend/.nuxt/dist/client/pages/search.js 2.2 kB 0 B
./frontend/.nuxt/dist/client/pages/search.modern.js 2.04 kB 0 B
./frontend/.nuxt/dist/client/pages/search/audio.js 3.69 kB 0 B
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 3.58 kB 0 B
./frontend/.nuxt/dist/client/pages/search/image.js 545 B 0 B
./frontend/.nuxt/dist/client/pages/search/image.modern.js 550 B 0 B
./frontend/.nuxt/dist/client/pages/search/index.js 443 B 0 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 446 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 243 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.js 266 B 0 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js 271 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.js 240 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 243 B 0 B
./frontend/.nuxt/dist/client/pages/sources.js 1.51 kB 0 B
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.51 kB 0 B
./frontend/.nuxt/dist/client/runtime.js 2.69 kB 0 B
./frontend/.nuxt/dist/client/runtime.modern.js 2.69 kB 0 B
./frontend/.nuxt/dist/client/vendors/app.js 64.6 kB 0 B
./frontend/.nuxt/dist/client/vendors/app.modern.js 63.7 kB 0 B

compressed-size-action

@obulat obulat self-assigned this May 16, 2023
@obulat obulat marked this pull request as ready for review May 16, 2023 13:18
@obulat obulat requested a review from a team as a code owner May 16, 2023 13:18
fcoveram
fcoveram reviewed May 16, 2023
View reviewed changes
frontend/src/components/VErrorSection/VNoResults.vue Outdated
class="label-bold !w-full justify-between text-dark-charcoal md:!w-auto md:justify-start md:gap-x-2"
variant="bordered-gray"
size="medium"
class="label-bold !w-full justify-between text-dark-charcoal md:!w-auto"
show-external-icon
:external-icon-size="4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon should update the size to 24px to match the button base component.

@obulat obulat requested a review from fcoveram May 16, 2023 14:42
@obulat obulat force-pushed the add/updated_external_sources_buttons branch 2 times, most recently from 7d8124c to 777d7d5 Compare May 17, 2023 09:08
@obulat obulat mentioned this pull request May 17, 2023
Merged
8 tasks
@obulat obulat changed the base branch from main to cleanup/old_variants May 17, 2023 09:13
@obulat obulat force-pushed the add/updated_external_sources_buttons branch from 777d7d5 to 81a31b2 Compare May 17, 2023 09:16
@obulat obulat mentioned this pull request May 17, 2023
Closed
9 tasks
@obulat obulat force-pushed the cleanup/old_variants branch from df26cd1 to 19d461c Compare May 17, 2023 09:35
@obulat obulat force-pushed the add/updated_external_sources_buttons branch from 81a31b2 to 5dce463 Compare May 17, 2023 09:42
@obulat obulat force-pushed the cleanup/old_variants branch from 19d461c to 122b379 Compare May 17, 2023 14:18
Base automatically changed from cleanup/old_variants to main May 18, 2023 07:35
fcoveram
fcoveram requested changes May 18, 2023
View reviewed changes
Copy link
Contributor

@fcoveram fcoveram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the following

  • Right padding is incorrect. It should be 8px as the button base.
  • In sm button should not be full width.

@obulat obulat force-pushed the add/updated_external_sources_buttons branch 4 times, most recently from 9d58690 to c14b391 Compare May 18, 2023 14:52
@obulat obulat requested a review from fcoveram May 18, 2023 14:52
@obulat obulat requested review from zackkrida and dhruvkb and removed request for sarayourfriend May 18, 2023 14:52
@obulat obulat force-pushed the add/updated_external_sources_buttons branch from c14b391 to 6ea1dbb Compare May 18, 2023 15:39
@obulat obulat force-pushed the add/updated_external_sources_buttons branch from 6ea1dbb to 165823a Compare May 18, 2023 15:48
fcoveram
fcoveram approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@fcoveram fcoveram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great ✨ 🚀

dhruvkb
dhruvkb approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. LGTM!

@obulat obulat merged commit 4cce861 into main May 19, 2023
@obulat obulat deleted the add/updated_external_sources_buttons branch May 19, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvkb dhruvkb dhruvkb approved these changes

@fcoveram fcoveram fcoveram approved these changes

@AetherUnbound AetherUnbound Awaiting requested review from AetherUnbound AetherUnbound is a code owner automatically assigned from WordPress/openverse-frontend

@zackkrida zackkrida Awaiting requested review from zackkrida

Assignees

@obulat obulat

Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obulat @fcoveram @dhruvkb