Remove the default `medium-old` size from buttons #2104

obulat · 2023-05-15T15:51:37Z

Fixes

Description

This PR makes the size prop for VButton required, and adds a value to all of the components that used the previously-default value of medium-old.

Testing Instructions

Check that the buttons look fine. The sizes will probably change, @fcoveram, could you verify that the buttons use the correct size?

Checklist

My pull request has a descriptive title (not a vague title likeUpdate index.md).
My pull request targets the default branch of the repository (main) or a parent feature branch.
My commit messages follow best practices.
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no visible errors.
I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

github-actions · 2023-05-15T15:59:53Z

Size Change: -38 B (0%)

Total Size: 833 kB

Filename	Size	Change
`./frontend/.nuxt/dist/client/app.js`	126 kB	-14 B (0%)
`./frontend/.nuxt/dist/client/app.modern.js`	117 kB	-24 B (0%)

ℹ️ View Unchanged

Filename	Size
`./frontend/.nuxt/dist/client/233.js`	272 B
`./frontend/.nuxt/dist/client/233.modern.js`	277 B
`./frontend/.nuxt/dist/client/234.js`	1.85 kB
`./frontend/.nuxt/dist/client/commons/app.js`	90.4 kB
`./frontend/.nuxt/dist/client/commons/app.modern.js`	78.5 kB
`./frontend/.nuxt/dist/client/components/loading-icon.js`	766 B
`./frontend/.nuxt/dist/client/components/loading-icon.modern.js`	769 B
`./frontend/.nuxt/dist/client/components/table-sort-icon.js`	514 B
`./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js`	519 B
`./frontend/.nuxt/dist/client/components/v-all-results-grid.js`	5.75 kB
`./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js`	5.62 kB
`./frontend/.nuxt/dist/client/components/v-audio-cell.js`	392 B
`./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js`	396 B
`./frontend/.nuxt/dist/client/components/v-audio-details.js`	2.35 kB
`./frontend/.nuxt/dist/client/components/v-audio-details.modern.js`	1.77 kB
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js`	1.01 kB
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js`	1.02 kB
`./frontend/.nuxt/dist/client/components/v-audio-track.js`	5.26 kB
`./frontend/.nuxt/dist/client/components/v-audio-track.modern.js`	5.21 kB
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js`	636 B
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js`	642 B
`./frontend/.nuxt/dist/client/components/v-bone.js`	688 B
`./frontend/.nuxt/dist/client/components/v-bone.modern.js`	692 B
`./frontend/.nuxt/dist/client/components/v-box-layout.js`	1.28 kB
`./frontend/.nuxt/dist/client/components/v-box-layout.modern.js`	1.27 kB
`./frontend/.nuxt/dist/client/components/v-content-link.js`	1.04 kB
`./frontend/.nuxt/dist/client/components/v-content-link.modern.js`	1.04 kB
`./frontend/.nuxt/dist/client/components/v-content-page.js`	524 B
`./frontend/.nuxt/dist/client/components/v-content-page.modern.js`	528 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.js`	493 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js`	497 B
`./frontend/.nuxt/dist/client/components/v-content-report-form.js`	3.86 kB
`./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js`	3.69 kB
`./frontend/.nuxt/dist/client/components/v-content-report-popover.js`	913 B
`./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js`	4.15 kB
`./frontend/.nuxt/dist/client/components/v-copy-button.js`	4 kB
`./frontend/.nuxt/dist/client/components/v-copy-button.modern.js`	4 kB
`./frontend/.nuxt/dist/client/components/v-copy-license.js`	2.09 kB
`./frontend/.nuxt/dist/client/components/v-copy-license.modern.js`	2.06 kB
`./frontend/.nuxt/dist/client/components/v-dmca-notice.js`	791 B
`./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js`	799 B
`./frontend/.nuxt/dist/client/components/v-error-image.js`	2.6 kB
`./frontend/.nuxt/dist/client/components/v-error-image.modern.js`	2.57 kB
`./frontend/.nuxt/dist/client/components/v-error-section.js`	372 B
`./frontend/.nuxt/dist/client/components/v-error-section.modern.js`	375 B
`./frontend/.nuxt/dist/client/components/v-external-search-form.js`	1.88 kB
`./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js`	1.87 kB
`./frontend/.nuxt/dist/client/components/v-external-source-list.js`	893 B
`./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js`	896 B
`./frontend/.nuxt/dist/client/components/v-full-layout.js`	1.56 kB
`./frontend/.nuxt/dist/client/components/v-full-layout.modern.js`	1.55 kB
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.js`	1.61 kB
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js`	1.62 kB
`./frontend/.nuxt/dist/client/components/v-home-gallery.js`	4.92 kB
`./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js`	4.9 kB
`./frontend/.nuxt/dist/client/components/v-homepage-content.js`	1.77 kB
`./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js`	1.74 kB
`./frontend/.nuxt/dist/client/components/v-image-carousel.js`	4.74 kB
`./frontend/.nuxt/dist/client/components/v-image-carousel.modern.js`	4.7 kB
`./frontend/.nuxt/dist/client/components/v-image-cell.js`	1.68 kB
`./frontend/.nuxt/dist/client/components/v-image-cell.modern.js`	1.67 kB
`./frontend/.nuxt/dist/client/components/v-image-details.js`	1.96 kB
`./frontend/.nuxt/dist/client/components/v-image-details.modern.js`	1.41 kB
`./frontend/.nuxt/dist/client/components/v-image-grid.js`	3.91 kB
`./frontend/.nuxt/dist/client/components/v-image-grid.modern.js`	3.79 kB
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.js`	641 B
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js`	649 B
`./frontend/.nuxt/dist/client/components/v-load-more.js`	844 B
`./frontend/.nuxt/dist/client/components/v-load-more.modern.js`	741 B
`./frontend/.nuxt/dist/client/components/v-media-license.js`	828 B
`./frontend/.nuxt/dist/client/components/v-media-license.modern.js`	836 B
`./frontend/.nuxt/dist/client/components/v-media-reuse.js`	2.69 kB
`./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js`	2.65 kB
`./frontend/.nuxt/dist/client/components/v-media-tag.js`	416 B
`./frontend/.nuxt/dist/client/components/v-media-tag.modern.js`	421 B
`./frontend/.nuxt/dist/client/components/v-modal.js`	1.01 kB
`./frontend/.nuxt/dist/client/components/v-modal.modern.js`	995 B
`./frontend/.nuxt/dist/client/components/v-no-results.js`	814 B
`./frontend/.nuxt/dist/client/components/v-no-results.modern.js`	816 B
`./frontend/.nuxt/dist/client/components/v-radio.js`	1.54 kB
`./frontend/.nuxt/dist/client/components/v-radio.modern.js`	1.5 kB
`./frontend/.nuxt/dist/client/components/v-related-audio.js`	1.29 kB
`./frontend/.nuxt/dist/client/components/v-related-audio.modern.js`	1.29 kB
`./frontend/.nuxt/dist/client/components/v-related-images.js`	1.1 kB
`./frontend/.nuxt/dist/client/components/v-related-images.modern.js`	1.1 kB
`./frontend/.nuxt/dist/client/components/v-report-desc-form.js`	977 B
`./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js`	979 B
`./frontend/.nuxt/dist/client/components/v-row-layout.js`	1.68 kB
`./frontend/.nuxt/dist/client/components/v-row-layout.modern.js`	1.68 kB
`./frontend/.nuxt/dist/client/components/v-scroll-button.js`	824 B
`./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js`	829 B
`./frontend/.nuxt/dist/client/components/v-search-grid.js`	6.55 kB
`./frontend/.nuxt/dist/client/components/v-search-grid.modern.js`	6.47 kB
`./frontend/.nuxt/dist/client/components/v-search-results-title.js`	618 B
`./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js`	622 B
`./frontend/.nuxt/dist/client/components/v-server-timeout.js`	299 B
`./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js`	303 B
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js`	1.01 kB
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js`	912 B
`./frontend/.nuxt/dist/client/components/v-snackbar.js`	1.16 kB
`./frontend/.nuxt/dist/client/components/v-snackbar.modern.js`	1.17 kB
`./frontend/.nuxt/dist/client/components/v-sources-table.js`	15.2 kB
`./frontend/.nuxt/dist/client/components/v-sources-table.modern.js`	15.2 kB
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.js`	306 B
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js`	311 B
`./frontend/.nuxt/dist/client/pages/about.js`	1.39 kB
`./frontend/.nuxt/dist/client/pages/about.modern.js`	1.4 kB
`./frontend/.nuxt/dist/client/pages/audio/_id/index.js`	6.52 kB
`./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js`	5.9 kB
`./frontend/.nuxt/dist/client/pages/external-sources.js`	1.55 kB
`./frontend/.nuxt/dist/client/pages/external-sources.modern.js`	1.56 kB
`./frontend/.nuxt/dist/client/pages/feedback.js`	1.34 kB
`./frontend/.nuxt/dist/client/pages/feedback.modern.js`	1.34 kB
`./frontend/.nuxt/dist/client/pages/image/_id/index.js`	7.46 kB
`./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js`	6.77 kB
`./frontend/.nuxt/dist/client/pages/image/_id/report.js`	2.23 kB
`./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js`	5.21 kB
`./frontend/.nuxt/dist/client/pages/index.js`	7.04 kB
`./frontend/.nuxt/dist/client/pages/index.modern.js`	6.96 kB
`./frontend/.nuxt/dist/client/pages/preferences.js`	1.3 kB
`./frontend/.nuxt/dist/client/pages/preferences.modern.js`	1.3 kB
`./frontend/.nuxt/dist/client/pages/privacy.js`	1.23 kB
`./frontend/.nuxt/dist/client/pages/privacy.modern.js`	1.24 kB
`./frontend/.nuxt/dist/client/pages/search-help.js`	1.59 kB
`./frontend/.nuxt/dist/client/pages/search-help.modern.js`	1.58 kB
`./frontend/.nuxt/dist/client/pages/search.js`	2.2 kB
`./frontend/.nuxt/dist/client/pages/search.modern.js`	2.04 kB
`./frontend/.nuxt/dist/client/pages/search/audio.js`	3.69 kB
`./frontend/.nuxt/dist/client/pages/search/audio.modern.js`	3.58 kB
`./frontend/.nuxt/dist/client/pages/search/image.js`	545 B
`./frontend/.nuxt/dist/client/pages/search/image.modern.js`	550 B
`./frontend/.nuxt/dist/client/pages/search/index.js`	443 B
`./frontend/.nuxt/dist/client/pages/search/index.modern.js`	446 B
`./frontend/.nuxt/dist/client/pages/search/model-3d.js`	243 B
`./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js`	246 B
`./frontend/.nuxt/dist/client/pages/search/search-page.types.js`	266 B
`./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js`	271 B
`./frontend/.nuxt/dist/client/pages/search/video.js`	240 B
`./frontend/.nuxt/dist/client/pages/search/video.modern.js`	243 B
`./frontend/.nuxt/dist/client/pages/sources.js`	1.51 kB
`./frontend/.nuxt/dist/client/pages/sources.modern.js`	1.51 kB
`./frontend/.nuxt/dist/client/runtime.js`	2.69 kB
`./frontend/.nuxt/dist/client/runtime.modern.js`	2.69 kB
`./frontend/.nuxt/dist/client/vendors/app.js`	64.6 kB
`./frontend/.nuxt/dist/client/vendors/app.modern.js`	63.7 kB

_{compressed-size-action}

github-actions · 2023-05-15T16:03:52Z

Full-stack documentation: https://docs.openverse.org/_preview/2104

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

zackkrida · 2023-05-15T22:10:43Z

@obulat if you don't mind I'm going to draft this while the VR tests are failing. Do you want a preliminary review from @fcoveram before they are fixed?

obulat · 2023-05-16T10:21:43Z

@obulat if you don't mind I'm going to draft this while the VR tests are failing. Do you want a preliminary review from @fcoveram before they are fixed?

Thank you for drafting it, I should be doing that for PRs that fail VR tests :)
I marked the PR as ready now that the tests pass. I do want @fcoveram's review especially for the VNoResult's buttons, and the text buttons. Should we replace the old text variant with filled-transparent variant? (One of those buttons is the "Clear filters" text button on the filters sidebar on desktop.

AetherUnbound

LGTM, I don't see any references to medium-old remaining 😄

zackkrida

LGTM!

fcoveram · 2023-05-18T08:16:27Z

review the VNoResult’s buttons, and the text buttons.

Which button is the “VNoResult”? and which are the “text buttons”?

Should we replace the old text variant with filled-transparent variant? (One of those buttons is the “Clear filters” text button on the filters sidebar on desktop.

Can you point out all the text variants?

I would appreciate a more specific review, otherwise I can't assess the time request for this review and might end up scanning all buttons in all pages.

obulat added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🧱 stack: frontend Related to the Nuxt frontend labels May 15, 2023

obulat requested a review from a team as a code owner May 15, 2023 15:51

obulat requested review from AetherUnbound and sarayourfriend May 15, 2023 15:51

github-actions bot added the 🧱 stack: documentation Related to Sphinx documentation label May 15, 2023

obulat force-pushed the cleanup/remove_old_sizes branch from 28cfb41 to bf90107 Compare May 15, 2023 15:52

zackkrida marked this pull request as draft May 15, 2023 22:10

obulat force-pushed the cleanup/remove_old_sizes branch 2 times, most recently from a42b8b0 to 34bb3f4 Compare May 16, 2023 08:37

github-actions bot added the 🧱 stack: mgmt Related to repo management and automations label May 16, 2023

obulat changed the base branch from main to add/updated_load_more May 16, 2023 09:19

obulat force-pushed the add/updated_load_more branch from 3e29893 to 033fc48 Compare May 16, 2023 09:20

obulat force-pushed the cleanup/remove_old_sizes branch from cd1a1df to 8b47d6c Compare May 16, 2023 09:22

obulat marked this pull request as ready for review May 16, 2023 09:44

Base automatically changed from add/updated_load_more to main May 16, 2023 11:22

obulat force-pushed the cleanup/remove_old_sizes branch from 8b47d6c to 9cb01aa Compare May 16, 2023 12:38

obulat marked this pull request as draft May 16, 2023 12:38

obulat force-pushed the cleanup/remove_old_sizes branch from 9cb01aa to 66c27a9 Compare May 16, 2023 13:22

obulat changed the base branch from main to add/updated_external_sources_buttons May 16, 2023 13:23

obulat force-pushed the add/updated_external_sources_buttons branch 3 times, most recently from 81a31b2 to 5dce463 Compare May 17, 2023 09:42

obulat mentioned this pull request May 17, 2023

Clean up after the buttons are implemented #1187

Closed

9 tasks

obulat force-pushed the cleanup/remove_old_sizes branch from 66c27a9 to dba4b4f Compare May 17, 2023 09:45

obulat self-assigned this May 17, 2023

obulat marked this pull request as ready for review May 17, 2023 10:01

obulat requested review from zackkrida and dhruvkb and removed request for sarayourfriend May 17, 2023 10:01

AetherUnbound approved these changes May 17, 2023

View reviewed changes

zackkrida approved these changes May 17, 2023

View reviewed changes

obulat force-pushed the add/updated_external_sources_buttons branch 5 times, most recently from 6ea1dbb to 165823a Compare May 18, 2023 15:48

obulat force-pushed the cleanup/remove_old_sizes branch from dba4b4f to 0daa881 Compare May 18, 2023 16:06

Base automatically changed from add/updated_external_sources_buttons to main May 19, 2023 03:32

obulat added 4 commits May 19, 2023 06:32

Remove old button sizes

a93b703

Add sizes to the button stories

a021767

Update storybook snapshots

a60af1a

Update snapshots

1d0b62f

obulat force-pushed the cleanup/remove_old_sizes branch from 0daa881 to 1d0b62f Compare May 19, 2023 03:32

obulat merged commit 8d2031b into main May 19, 2023

obulat deleted the cleanup/remove_old_sizes branch May 19, 2023 11:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the default `medium-old` size from buttons #2104

Remove the default `medium-old` size from buttons #2104

obulat commented May 15, 2023 •

edited

Loading

github-actions bot commented May 15, 2023 •

edited

Loading

github-actions bot commented May 15, 2023

zackkrida commented May 15, 2023

obulat commented May 16, 2023

AetherUnbound left a comment

zackkrida left a comment

fcoveram commented May 18, 2023

Remove the default medium-old size from buttons #2104

Remove the default medium-old size from buttons #2104

Conversation

obulat commented May 15, 2023 • edited Loading

Fixes

Description

Testing Instructions

Checklist

Developer Certificate of Origin

github-actions bot commented May 15, 2023 • edited Loading

github-actions bot commented May 15, 2023

zackkrida commented May 15, 2023

obulat commented May 16, 2023

AetherUnbound left a comment

Choose a reason for hiding this comment

zackkrida left a comment

Choose a reason for hiding this comment

fcoveram commented May 18, 2023

Remove the default `medium-old` size from buttons #2104

Remove the default `medium-old` size from buttons #2104

obulat commented May 15, 2023 •

edited

Loading

github-actions bot commented May 15, 2023 •

edited

Loading