Update the CTA buttons #1049
Merged
Update the CTA buttons #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -205 B (0%) Total Size: 844 kB
ℹ️ View Unchanged
|
|
Full-stack documentation: https://docs.openverse.org/_preview/1049 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
obulat
added
🟨 priority: medium
obulat
commented
Mar 28, 2023
obulat
force-pushed
the
add_new_buttons
branch
4 times, most recently
from
eb15997 to
64374df
Compare
|
Based on this PR, I added a new comment in #860 suggesting a spacing update. |
obulat
force-pushed
the
add_new_buttons
branch
2 times, most recently
from
f2c3ce3 to
e37ce56
Compare
obulat
added
the
✨ goal: improvement
zackkrida
requested changes
Apr 10, 2023
fcoveram
approved these changes
Apr 11, 2023
|
The center-aligned version definitely looks better @zackkrida, but the problem is rooted in the control button size. It's not part of this update, but it should be tackled after updating the components list. To me is not a blocker as we are aware of this issue and need to solve it after updating the button components. But I will leave it to @obulat to decide. |
Great catch! I've updated the button to make it center-align with the Play button. To do that, I used vertical margins ( Current prod, the button becomes tall and narrow: This PR, the button keeps its shape and is always aligned to the center of the play button: |
6 tasks
7 tasks
dhruvkb
pushed a commit
that referenced
this pull request
Apr 14, 2023
* Use Python to group items by license to speed up the query Signed-off-by: Olga Bulat <[email protected]> * Remove unnecessary type conversions Signed-off-by: Olga Bulat <[email protected]> * Lowercase the license names; save the invalid values to S3 Signed-off-by: Olga Bulat <[email protected]> * Use a tempfile for invalid items Signed-off-by: Olga Bulat <[email protected]> --------- Signed-off-by: Olga Bulat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #1020 by @obulat
Description
This PR applies the new button styles to the CTAs according to the Figma files: https://www.figma.com/file/es303VxVr0C7rFTcOe3OXL/Core-interface-improvement?node-id=950-7110&t=ofmQkfpwZhitIllp-4
The external icons are removed because we can add them by setting
show-external-iconprop, which will be passed to theVLinkcomponent.Testing Instructions
The CI should work, and the snapshots look correct and match the Figma mockups.
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin