Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absorb actionlint into pre-commit #1028

Merged
merged 10 commits into from
Apr 2, 2023
Merged

Absorb actionlint into pre-commit #1028

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
297e87b
Absorbed actionlint into pre-commit
AdarshRawat1 Mar 25, 2023
21f29fc
Added 'actionlint' to pre-commit-config template
AdarshRawat1 Mar 25, 2023
5ab00ab
Added `actionlint` to pre-commit-config
AdarshRawat1 Mar 25, 2023
0fdf652
removed extra whitespaces
AdarshRawat1 Mar 25, 2023
569bdff
Update templates/.pre-commit-config.yaml.jinja
AdarshRawat1 Mar 31, 2023
3c4713b
Merge branch 'main' into Absorb-actionlint
AdarshRawat1 Mar 31, 2023
ad750b7
Update .pre-commit-config.yaml
AdarshRawat1 Mar 31, 2023
38680af
Removed the files directive for actionlint-docker.
AdarshRawat1 Apr 2, 2023
ee26867
Fix template to pass lint checks
dhruvkb Apr 2, 2023
756e937
Merge branch 'main' into Absorb-actionlint
sarayourfriend Apr 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions .github/workflows/actionlint.yml
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@ repos:
hooks:
- id: shellcheck

- repo: https://github.com/rhysd/actionlint
rev: main
hooks:
- id: actionlint
AdarshRawat1 marked this conversation as resolved.
Show resolved Hide resolved

- repo: local # More local hooks are defined at the top.
hooks:
- id: types
Expand Down
6 changes: 6 additions & 0 deletions templates/.pre-commit-config.yaml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@ repos:
# See the following documentation for what each rule does:
# https://www.pydocstyle.org/en/6.2.3/error_codes.html#error-codes
- --add-ignore=D1,D202,D205,D211,D400

- repo: https://github.com/rhysd/actionlint
rev: main
hooks:
- id: actionlint-docker
files: ^\.github/(workflows|actions)/.*$

{% endif %}
{% if contains_js_code | default(true) %}
Expand Down