-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta search should be disabled on all content results #533
Comments
I would be interested in resolving this bug. |
@panchovm I'm concerned about hiding this feature form our default search view. What do you think if we showed multiple dropdowns, one for each content type, or a single dropdown grouped by "image", "audio" and so on? We'd also need to change the language to "Try additional sources", removing the media type. |
Why are you concerned? I think that showing the metasearch forces this layout unnecessarily. The external sources list is for visitors not finding what they want, and that makes more sense doing it on the content type result after loading several results. I am curious to hear other thoughts. |
I agree with @zackkrida that we should add a more generic search text. const metaSearchFormType = computed(() => {
if (mediaTypes.includes(props.searchType)) {
return props.searchType
}
return IMAGE
}) |
Not sure if I understood your point @ramadanomar correctly. Are you agree showing or hiding the metasearch section? |
Sorry! I think we should keep the metasearch section but change the copy to something more generic |
Any update on this issue? |
My thinking here, @panchovm was that I don't like conditionally showing/hiding pieces of the UI without the user knowing about it. A similar concern I have is in the filter sidebar. That might be a good example. I plan to make an issue for this today, but I do not like how the filter sidebar has fewer filters on the 'all results' view than the single media type views. Of course, this is necessary, but I think it would be great to have a message at the bottom of the filterbar that says something like 'Choose a single media type to view detailed source and media-specific filters', something like that. My logic here is the same. I don't want 'all results' to be an inadequate experience if it doesn't have to be. |
I didn't understand this point, but I understand the core of your concern. If we think is useful, then let's tag it with
Showing more or fewer filters should not be a concern as far as they relate to the result on the left. I have discussed this several times with other designers when designing the header interaction and tabs for content type/filters. Showing filters that impact just a portion of the results, like
Fully agree with you. And because of that, I need to insist on an argument mentioned in previous discussions: if we do not know how visitors value and interact with this page, then we should not add more features. |
I agree with this and definitely do not want to do it. I just want users to know that more filters are available. That's my core concern: if we have features that are only available in certain views, that aren't the default view, how can we make sure users know about them?
I'm not sure I agree with this. I definitely want user data to inform our decisions as much as possible, but there occasions where we have to use our expertise to make a best-guess. For example, we have no way of knowing how many Openverse users use screenreaders. Does that mean we shouldn't make things accessible? I don't think so, because accessibility is something we value and think is valuable to users, even if its a small subset of users. I think we can work towards getting more data and make best-guess desicions using our judgement at the same time. |
Now I understand better your point about filters. And I agree with you to convey the set of features for interacting with content. Regarding knowing openverse visitors, I understand that completely. Especially as a designer having to design without content or stats to support design decisions. And that should not stop us from making a product, definitely. My point was about what we consider an "inadequate experience". From a design perspective, features must explain themselves by matching people's expectations and their mental models. But this product definition discussion also relates to the decision-making process and what set of features we decide to set and follow. In that vein, a11y is a foundational aspect of the web and design, and both should embrace it at their cores. |
Hi there. My intuitive thoughts are: Having 'Metasearch' is a good thing. After researching at Openverse, I'd need additional resources to find the appropriate content. Way to have it, while not overwhelming the user, in my opinion, is:
To expand.
Additionally. Hope this helps. |
Great thoughts all around! Regardless of when/where/how the meta-search tool shows up, I would echo the opportunity to minimize its design to have less prominence, which could in turn make feature more glancable/actionable. Whether it shows up only on individual filters, or even on the "all content search" I have a less strong opinion about. But it's worth noting that even if it does show up everywhere, the content of the dropdown will still change, as it doesn't make sense to suggest "soundcloud" on the Image filter, for example. |
The Metasearch is definitely a great feature. It allows visitors to find relevant content when they do not find something in Openverse. I agree with you @marko-srb that it makes more sense to show the external sites in the single-content results as it is consistent with the content seeking. The dropdown design idea was already designed, but its implementation in WordPress/openverse-frontend#734 is blocked by a shift in the term used for the sources in WordPress/openverse-frontend#1197. Your point @jasmussen aligns with mine about adding a browsing complexity to the meaning of this page. If we go with keeping the feature, it would be necessary to split the dropdown and create a new variant of the menu. Thanks for jumping in and sharing your thoughts. |
Totally agree with visually minimizing the meta search feature, which should land in this PR in the next week: WordPress/openverse-frontend#1665 The descriptions from @marko-srb about the desired user flow make sense to me. I'm still of the opinion that always having the feature at the bottom of the results with a scoped dropdown only containing the relevant media types is best for the sake of consistency and predictability. I don't see how doing so would be detrimental. Ignore my horrible styling but you get the idea: I am fine with hiding it on the 'all results' view and unblocking this, however. Once we make progress on some analytics work and find out how often this feature is actually used, we'll be better able to make decisions about where to display it. |
I like this idea. I am putting down the questions we want to respond to with user data. To continue, I will remove the |
@fcoveram, what if instead of hiding this on all results views, we show all of the external sources there? And to make it clear which media type the source has, we add a content type icon to the button (or another indication)? I tried adding it to the new popover: |
All my points shared in previous messages on why not showing this component are rooted in the usefulness of this element and the idea of keeping a simple design, not about its visual style. I thought we concluded this conversation with this message from Zack:
|
Description
In all content results, the meta search section is visible at the end of the grid. This should be disabled as the section was designed to list sources related to a single content type and not multiple, as in this layout case. This logic applies to the outdated and the new design.
Reproduction
Screenshots
Resolution
The text was updated successfully, but these errors were encountered: