Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from popper.js to floating-ui #506

Closed
zackkrida opened this issue Sep 8, 2022 · 0 comments · Fixed by #3406
Closed

Update from popper.js to floating-ui #506

zackkrida opened this issue Sep 8, 2022 · 0 comments · Fixed by #3406
Assignees
@obulat
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend 🟨 tech: javascript Involves JavaScript

Comments

@zackkrida
Copy link
Member

The maintainers of popper js have moved on to a lower-level library called floating-ui. The library purports to be smaller, faster, and offer more customization options to users.

We should migrate over to this library, using their migration guide, to ensure future support and stability of our popovers.
@zackkrida zackkrida added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature labels Sep 8, 2022
@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🟨 tech: javascript Involves JavaScript and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Sep 9, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
dhruvkb pushed a commit that referenced this issue Apr 14, 2023
@stacimc
Ensure SMK images don't timeout on validation (#506)
bba0413 
* Rename Staten Museum to SMK

* Request smaller images

* Add support for legacy (non IIIF-enabled) images

* Update and add new tests

* Update provider name in DB
@obulat obulat self-assigned this Nov 28, 2023
@obulat obulat moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Nov 28, 2023
@obulat obulat mentioned this issue Nov 28, 2023
Merged
8 tasks
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Nov 28, 2023
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obulat obulat

Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend 🟨 tech: javascript Involves JavaScript
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace popper.js with floating-ui WordPress/openverse
3 participants
@zackkrida @obulat @dhruvkb