Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature flag to show the dark mode UI toggle #4306

Closed
zackkrida opened this issue May 10, 2024 · 0 comments · Fixed by #4809
Closed

Add a feature flag to show the dark mode UI toggle #4306

zackkrida opened this issue May 10, 2024 · 0 comments · Fixed by #4809
Assignees
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@zackkrida
Copy link
Member

This issue is part of the Dark Mode project: #3592. Please see the implementation plan for additional detail and context.

Description

Create a dark_mode_ui_toggle feature flag, which is off by default and switchable in staging. This will be used to conditionally render a new UI toggle for dark mode. You can view the designs here #4155.

The flag should have the following state:

{
   "dark_mode_ui_toggle": {
      "status": {
        "staging": "switchable",
        "production": "disabled"
      },
      "defaultState": "off",
      "description": "Display the UI toggle to change the site theme.",
      "storage": "cookie"
    }
}

This PR is only concerned with adding the flag, it does not need to implement the component.

@zackkrida zackkrida added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: frontend Related to the Nuxt frontend labels May 10, 2024
@zackkrida zackkrida added this to the Dark Mode B - Toggle milestone May 10, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog May 10, 2024
@zackkrida zackkrida self-assigned this Aug 26, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Aug 26, 2024
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Aug 26, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant