Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #3592

Open
8 of 9 tasks
fcoveram opened this issue Dec 27, 2023 · 18 comments
Open
8 of 9 tasks

Dark mode #3592

fcoveram opened this issue Dec 27, 2023 · 18 comments
Assignees
Labels
design: ready Issue with a mockup ready for implementation 🧭 project: thread An issue used to track a project and its progress 🧱 stack: frontend Related to the Nuxt frontend

Comments

@fcoveram
Copy link
Contributor

fcoveram commented Dec 27, 2023

Description

Include a feature that changes the UI from light to a dark color scheme.

Background

Dark mode is a product-wide setting that adapts the user interface to provide a comfortable experience in low-light environments and, in some cases, improve accessibility for those with visual impairments, as pointed out by NN/g.

As described in Material Design documentation, dark themes also reduce the luminance emitted by device screens and conserve battery power, as devices with OLED screens benefit from the ability to turn off black pixels at any time of day.

Documents

Designs

Milestones/Issues

These milestones can be worked on in parallel:

Launch Plan

See launch plan here.

@fcoveram fcoveram added 🧭 project: thread An issue used to track a project and its progress 🧱 stack: frontend Related to the Nuxt frontend design: needed Needs a designer's touch before implementation can begin labels Dec 27, 2023
@zackkrida
Copy link
Member

Hi @fcoveram! Once you're ready with some preliminary designs, it would be excellent if you could update the project status and begin a proposal. The priority here hasn't changed or anything, I'm just following up on last month's priorities meeting.

@fcoveram
Copy link
Contributor Author

Update 2024-03-25

@openverse-bot
Copy link
Collaborator

Hi @fcoveram, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information.

@fcoveram
Copy link
Contributor Author

Update on 2024-04-16

  • Feedback on Dark mode designs were positive and two design tasks remain. Those will be shared in new tickets.
  • Frontend implementation plan is still in progress.

@openverse-bot
Copy link
Collaborator

Hi @fcoveram, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information.

@fcoveram
Copy link
Contributor Author

fcoveram commented May 1, 2024

Update on 2024-05-01

@zackkrida zackkrida assigned zackkrida and unassigned fcoveram May 1, 2024
@zackkrida
Copy link
Member

zackkrida commented May 1, 2024

The implementation plan for the project is approved and merged.

Next, I will create issues and milestones for the project. Once created I will outline the workflows and link to the milestones in the project issue body. At that point I will move the project to "On Hold" while we work on the Nuxt 3 migration. This will not be worked on until that project is completed, or is again put on hold due to limiting circumstances.

@zackkrida zackkrida assigned fcoveram and unassigned zackkrida May 1, 2024
@krysal krysal added this to the Dark Mode milestone May 6, 2024
@zackkrida
Copy link
Member

Update 05-10-2024

All issues and milestones have been created and added to the parent issue ✨. The project is ready to be worked on but will be moved to "On Hold".

There is some remaining work around color names that I raised here and am awaiting reply.

@fcoveram
Copy link
Contributor Author

Update 14-05-2024

cc: @zackkrida

@fcoveram fcoveram added design: ready Issue with a mockup ready for implementation and removed design: needed Needs a designer's touch before implementation can begin labels May 14, 2024
@zackkrida zackkrida assigned zackkrida and unassigned fcoveram Aug 1, 2024
@zackkrida zackkrida removed this from the Dark Mode A - Color Palette milestone Aug 1, 2024
@zackkrida
Copy link
Member

zackkrida commented Aug 1, 2024

Update 2024-07-31

I've initialized work on dark mode in light of the successful Nuxt 3 deployment. I've put up a PR for the first part of the "color palette" milestone. That milestone introduces the dark mode colors but doesn't expose them to end users.

#4687

I've also created an initial PR to add the dark mode color palette. It's close to being ready for review:

#4690

After that, the first milestone will be closed when we add visual regression tests and store screenshots for the dark version of components.

@zackkrida
Copy link
Member

Update 2024-08-12

The first dark mode milestone is nearly completed, with one issue remaining #4305.

But first, we need to do two things:

  • review the dark mode for improvements, issues, or concerns. @fcoveram will be able to start this next week.
  • Complete the second milestone, which creates the UI and code necessary to toggle and introduce dark mode.

Once those are both completed, we can "lock in" the visual regression tests for dark mode.

Given that our Storybook Playwright tests are paused, I will constrain the scope of that issue to creating dark mode page screenshots for now.

@openverse-bot
Copy link
Collaborator

Hi @zackkrida, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information.

@zackkrida
Copy link
Member

Update 2024-08-27

Progress! Dark mode is under extensive community review in #4783, with @obulat already pushing some improvements in #4808.

Work has begun on the second milestone. I've started writing the basic prerequisites in #4809 and #4810, while @dhruvkb plans to implement the Dark mode toggle component.

@fcoveram
Copy link
Contributor Author

Yesterday, I spent half a day cleaning up some views to support dark mode. If you have edit permission in the Design Library, you can easily switch the theme of mockup sections marked as "ready for dev."

To avoid unintentional changes in the file, it is highly recommended that you switch between design and dev modes (Shift + D) and use the hand tool (H) to move around the file.

CleanShot.2024-08-29.at.10.02.27.mp4

@openverse-bot
Copy link
Collaborator

Hi @zackkrida, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information.

@dhruvkb
Copy link
Member

dhruvkb commented Sep 18, 2024

Update 2024-09-19

Important

The notice currently points to the Make site. The URL must be updated when the Make post has been published.

see-more-href="https://make.wordpress.org/openverse/"

@openverse-bot
Copy link
Collaborator

Hi @zackkrida, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information.

1 similar comment
@openverse-bot
Copy link
Collaborator

Hi @zackkrida, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information.

@obulat obulat assigned obulat and unassigned obulat Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: ready Issue with a mockup ready for implementation 🧭 project: thread An issue used to track a project and its progress 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 🚧 In Progress
Development

No branches or pull requests

6 participants