-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode #3592
Comments
Hi @fcoveram! Once you're ready with some preliminary designs, it would be excellent if you could update the project status and begin a proposal. The priority here hasn't changed or anything, I'm just following up on last month's priorities meeting. |
Update 2024-03-25
|
Hi @fcoveram, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information. |
Update on 2024-04-16
|
Hi @fcoveram, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information. |
Update on 2024-05-01
|
The implementation plan for the project is approved and merged. Next, I will create issues and milestones for the project. Once created I will outline the workflows and link to the milestones in the project issue body. At that point I will move the project to "On Hold" while we work on the Nuxt 3 migration. This will not be worked on until that project is completed, or is again put on hold due to limiting circumstances. |
Update 05-10-2024All issues and milestones have been created and added to the parent issue ✨. The project is ready to be worked on but will be moved to "On Hold". There is some remaining work around color names that I raised here and am awaiting reply. |
Update 14-05-2024
cc: @zackkrida |
Update 2024-07-31I've initialized work on dark mode in light of the successful Nuxt 3 deployment. I've put up a PR for the first part of the "color palette" milestone. That milestone introduces the dark mode colors but doesn't expose them to end users. I've also created an initial PR to add the dark mode color palette. It's close to being ready for review: After that, the first milestone will be closed when we add visual regression tests and store screenshots for the dark version of components. |
Update 2024-08-12The first dark mode milestone is nearly completed, with one issue remaining #4305. But first, we need to do two things:
Once those are both completed, we can "lock in" the visual regression tests for dark mode. Given that our Storybook Playwright tests are paused, I will constrain the scope of that issue to creating dark mode page screenshots for now. |
Hi @zackkrida, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information. |
Update 2024-08-27Progress! Dark mode is under extensive community review in #4783, with @obulat already pushing some improvements in #4808. Work has begun on the second milestone. I've started writing the basic prerequisites in #4809 and #4810, while @dhruvkb plans to implement the Dark mode toggle component. |
Yesterday, I spent half a day cleaning up some views to support dark mode. If you have edit permission in the Design Library, you can easily switch the theme of mockup sections marked as "ready for dev." To avoid unintentional changes in the file, it is highly recommended that you switch between design and dev modes ( CleanShot.2024-08-29.at.10.02.27.mp4 |
Hi @zackkrida, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information. |
Update 2024-09-19
Important The notice currently points to the Make site. The URL must be updated when the Make post has been published.
|
Hi @zackkrida, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information. |
1 similar comment
Hi @zackkrida, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information. |
Description
Include a feature that changes the UI from light to a dark color scheme.
Background
Dark mode is a product-wide setting that adapts the user interface to provide a comfortable experience in low-light environments and, in some cases, improve accessibility for those with visual impairments, as pointed out by NN/g.
As described in Material Design documentation, dark themes also reduce the luminance emitted by device screens and conserve battery power, as devices with OLED screens benefit from the ability to turn off black pixels at any time of day.
Documents
Designs
Milestones/Issues
These milestones can be worked on in parallel:
Launch Plan
See launch plan here.
The text was updated successfully, but these errors were encountered: