-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter and blur sensitive results by term matching #377
Comments
Update 2023-03-07Frontend design work is taking place here. This work assumes that the MVP of this functionality will allow the user to show sensitive results, and to elect to blur sensitive results in the search results view (with blurring as the default value). We also assume the MVP of this functionality does not display or allow the user to enable specific sensitive content subcategories. However, this active design work will be easily adaptable and compatible with such functionality if we decide to include it. Done
Next
BlockersI have been delayed in publishing my recommendations for a sensitive content terms list for Openverse, but will do so by the end of the week. |
@zackkrida This project currently has the "In RFC" status, but it looks like that means we're skipping the project planning step of this. Is that intentional? I want to clarify before I get to deeply into writing the implementation plan. |
Further clarification: are these separate features? Is this re-wording of the quoted summary accurate? "We will enhance our data for what a "sensitive" result might be, thereby filtering them out of queries that do not have The part I want to clarify here is whether we expect results with sensitive terms to appear in queries where mature is not |
Hi @sarayourfriend! I've fixed the project status to 'In Kickoff'. I erroneously moved it there when the design proposal was created, as I forgot this project included the full scope of the term matching and not just the frontend blurring implementation. I was of the opinion that we'd want a proposal and implementation plan here, but would like your opinion. To clarify the update points about the design work: Users opt-in to seeing sensitive search results. After opting in, blurred sensitive results will be displayed in their search results. If desired, they can further opt-in to unblur these results. Users will not see sensitive results (those marked as For single results, how does this sound: Individual results will be blurred for all users when visited directly by url, regardless of specified user preferences. Sensitive results will only be unblurred when navigated to from a search results view where 'show sensitive results' is enabled and 'blur sensitive results' is disabled. |
@panchovm and I decided that it might be best to pause design work after soliciting feedback on the latest iteration of the design. This is primarily to prevent us from having to make further assumptions that may contradict the upcoming planning documents. The designs are in a place where some preliminary development can start (or resume, considering #824) behind a feature flag while we continue to plan. |
Thanks for the clarifications on all accounts. They sound great. I've got about half a technical implementation plan written for this, it turns out the most difficult part will probably be designating which results have sensitive terms in their textual content in the search API in a way that does not degrade performance. I'll write the kickoff post first and get the project planning generally started. Having technical implementation plans is a good idea here. Blurring likely deserves its own consideration unless we decide to just use regular CSS blurring, but it's something we can discuss in the kickoff discussion. |
I also like Google's solution, but there are other product-wise considerations pointed out here. But definitely something to keep in mind. |
Oh, I see. You are right. The interface needs to provide more context. Good point. |
I am not sure the global player needs to be blurred because for it to appear, the user must click a result, choose to unblur that result from the content safety wall, see everything in the single result view, play the audio and then go back to all results. After this has happened, the result item itself is unblurred so the global player playing that item need not be blurred. As for the eye icon on the blurred images, I would be in favour of a visual context but I am not sure what the best way to indicate this is. I played a bit with the idea and have three thoughts.
@fcoveram your design input about these points will be very helpful, thanks. |
Global player
I agree with this. I'm referring to the flow when users play a blurred audio track in the search results page. If the item has not been unblurred, and you click on play, the global player should also show blurred info. In other words, global player should mirror the audio track state. Here is a quick prototype of this flow. Global.player.blurred.mp4Icon indicatorI tried different styles for the icon, and a black icon over a white layer with 60% opacity might work. The ratio contrast required for graphics is lower than for texts. However, the consistency between media types is my main concern. After testing some ideas, I concluded that the designed consent flow (landing in the search results and enabling the sensitive results) is sufficient for conveying why some content (images and texts) is blurred. The change in the results area is very clear in that new content was added. |
The project is very close to completion, with a total of 5 tickets, including 1 blocked ticket (#2550 that needs legal input) and 3 that already have PRs associated with them. The API ticket for |
I'm reaching out to the legal team again to ask for clarification on when we can expect a response. The last time I asked they didn't respond 😕 |
Hi @dhruvkb, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information. |
The latest on this is that we have heard back from legal and these discussions brought up some actionable items:
@sarayourfriend has already implemented points 1 and 2 (thanks! 👏) so I think it should be time to formalise the text into a page on Openverse.org. The third will soon be implemented as a part of that project. |
Hi @dhruvkb, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information. |
This has been shipped to production 🎈 🥳 🎉 ! One issue #3081 remains in the milestone blocked on the official translations to be written for the content safety explanation page. |
The last issue in the milestone has also been resolved now. The project is shipped! |
I've drafted an announcement post for the feature here: Google Docs Link. @dhruvkb and @WordPress/openverse-maintainers - please take a look and let me know if it sounds okay! I can post it this week and we can move this to "Success" 😄 🚀 |
I will share the document with rmartinezduque asking for feedback. |
Congrats on shipping this new feature! The post looks great to me. I think it clearly communicates the new feature and the benefits it brings. I only suggested a few minor edits, mostly to correct a grammar mistake. If possible, I think it would also be nice to include an image to accompany the announcement (perhaps you already have it in mind). 🙂 |
I can work on a visual for the post ⭐ |
Thank you @rmartinezduque and @fcoveram! |
Our announcement P2 has been made: https://make.wordpress.org/openverse/2023/12/11/introducing-enhanced-content-safety-features-on-openverse/ And I've also made an amplification request for the marketing team here: WordPress/Marketing-Team#330 With that, I'm going to move this project to "Success"! |
Description
This project matches Openverse images against a list of sensitive terms. All sensitive single image results on the frontend are blurred and viewing them is opt-in for all users.
Development work is ongoing and tracked in a milestone: https://github.com/WordPress/openverse/milestone/12
Documents
Issues
Prior Art
The text was updated successfully, but these errors were encountered: