Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single result endpoint does not return correctly populated sensitivity #2926

Closed
sarayourfriend opened this issue Aug 31, 2023 · 0 comments · Fixed by #3013
Closed

Single result endpoint does not return correctly populated sensitivity #2926

sarayourfriend opened this issue Aug 31, 2023 · 0 comments · Fixed by #3013
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API

Comments

@sarayourfriend
Copy link
Collaborator

Description

The single results endpoint does not populate unstable__sensitivity. This prevents the frontend from blurring sensitive results loaded from direct links.

Reproduction is easy on production. I don't share direct links because I am using results that are designated with sensitive textual content in production (though I believe this example to be a false positive). It is possible to reproduce locally using the testing sensitive terms present locally (running, water, and birds). Just choose a result that is designated to have sensitive text by the testing terms and load it's single result. It will not have the sensitive textual content designation in unstable__sensitivity.

Reproduction

  1. Search `api.openverse.engineering/v1/audio/` with `?q=Sofia's Dawn Chorus&unstable__include_sensitive_results=true`. This returns just one result titled "Sofia's Dawn Chorus" that is designated as having sensitive textual content. Verify this in the `unstable__sensitivity` array on the result in the results list.
  2. Visit the detail url for that result, UUID `06ea8f9b-68b0-4ffd-939b-cb020ad70b0e`.
  3. `unstable__sensitivity` will be an empty array.

Additional context

Marked high because it prevents the frontend's sensitivity feature roll out. cc @dhruvkb as a heads up to the project lead.

@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software 🧱 stack: api Related to the Django API labels Aug 31, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Aug 31, 2023
@obulat obulat moved this from 📋 Backlog to 📅 To do in Openverse Backlog Sep 5, 2023
@dhruvkb dhruvkb self-assigned this Sep 11, 2023
@sarayourfriend sarayourfriend moved this from 📅 To do to 🏗 In progress in Openverse Backlog Sep 11, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Openverse Backlog Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants