Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the pretty-format-json hook from this and other repositories #317

Closed
obulat opened this issue Oct 19, 2022 · 1 comment · Fixed by #332
Closed

Remove the pretty-format-json hook from this and other repositories #317

obulat opened this issue Oct 19, 2022 · 1 comment · Fixed by #332
Assignees
@dhruvkb
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents

Comments

@obulat
Copy link
Contributor

obulat commented Oct 19, 2022

Description

This repository has https://github.com/pre-commit/pre-commit-hooks#pretty-format-json hook while other repositories probably do not. The requirements for linting json files thus differs between repositories. This difference causes extra sync requests when the json files from this repositories have different format than the json files in other repositories (and no other changes).

This PR was failing CI:
WordPress/openverse-frontend#1917
I've fixed linting errors, and then merged them in. After that, a new sync PR was opened with identical changes but different formatting:
WordPress/openverse-frontend#1920

This issue is marked as high priority because not fixing it causes a drift between repository configs.
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Oct 19, 2022
@dhruvkb dhruvkb added good first issue New-contributor friendly help wanted Open to participation from the community labels Oct 19, 2022
@dhruvkb dhruvkb mentioned this issue Oct 20, 2022
Closed
@dhruvkb dhruvkb self-assigned this Nov 15, 2022
@dhruvkb
Copy link
Member

dhruvkb commented Nov 15, 2022

WordPress/openverse-frontend#1960 is in perpetual freeze because of this.

@dhruvkb dhruvkb mentioned this issue Nov 16, 2022
Merged
7 tasks
dhruvkb added a commit that referenced this issue Feb 20, 2023
@dhruvkb
🔄 Synced file(s) with WordPress/openverse (#317)
df05ac6
dhruvkb added a commit that referenced this issue Apr 14, 2023
@dhruvkb
🔄 Synced file(s) with WordPress/openverse (#317)
52c1d24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvkb dhruvkb

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand Prettier to eliminate pretty-format-json WordPress/openverse
2 participants
@obulat @dhruvkb