Wrap PR and discussion titles in toJSON to escape them in Slack

WordPress · Jan 24, 2024 · e9b3de6 · e9b3de6
1 parent 8e21893
commit e9b3de6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml
@@ -13,7 +13,7 @@ jobs:
     env:
       discussion_url: ${{ github.event.discussion.html_url }}
       discussion_number: ${{ github.event.discussion.number }}
-      discussion_title: ${{ github.event.discussion.title }}
+      discussion_title: ${{ toJSON(github.event.discussion.title) }}
       discussion_author: ${{ github.event.discussion.user.login }}
       discussion_repo: ${{ github.event.repository.full_name }}
       SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

diff --git a/.github/workflows/pr_ping.yml b/.github/workflows/pr_ping.yml
@@ -17,7 +17,7 @@ jobs:
     env:
       pr_url: ${{ github.event.pull_request.html_url }}
       pr_number: ${{ github.event.pull_request.number }}
-      pr_title: ${{ github.event.pull_request.title }}
+      pr_title: ${{ toJSON(github.event.pull_request.title) }}
       pr_author: ${{ github.event.pull_request.user.login }}
       pr_repo: ${{ github.event.pull_request.base.repo.full_name }}
       SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
@@ -33,7 +33,7 @@ jobs:
         with:
           payload: |
             {
-              "text": "New ${{ env.pr_status }} PR opened by ${{ env.pr_author }} in ${{ env.pr_repo }}: #${{ env.pr_number }} - ${{ env.pr_title }}",
+              "text": "New${{ env.pr_status }}PR opened by ${{ env.pr_author }} in ${{ env.pr_repo }}: #${{ env.pr_number }} - ${{ env.pr_title }}",
               "blocks": [
                 {
                   "type": "section",