Skip to content

Commit

Permalink
Resolve flakiness in global audio player VR tests (#3021)
Browse files Browse the repository at this point in the history
* Use longer track for increased reliability in interactions

* Wait for network idle before snapshot

* Remove the issue comment

Co-authored-by: sarayourfriend <[email protected]>

* Revert to the shorter track

---------

Co-authored-by: sarayourfriend <[email protected]>
  • Loading branch information
dhruvkb and sarayourfriend authored Sep 14, 2023
1 parent 7aaa2f2 commit 9e63905
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ import audio from "~~/test/playwright/utils/audio"

for (const dir of languageDirections) {
breakpoints.describeXs(async ({ expectSnapshot }) => {
// https://github.com/WordPress/openverse/issues/3009
test.skip(`Global audio player on the search page - ${dir}`, async ({
test(`Global audio player on the search page - ${dir}`, async ({
page,
}) => {
await dismissTranslationBanner(page)
Expand All @@ -29,6 +28,9 @@ for (const dir of languageDirections) {
.click()
// To make the tests consistent, set the played area to the same position
await page.mouse.click(170, 650)
// Allow audio to buffer to the seeked position
// eslint-disable-next-line playwright/no-networkidle
await page.waitForLoadState("networkidle")
await expectSnapshot(`global-audio-player-on-search-${dir}.png`, page)
})
})
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 9e63905

Please sign in to comment.