Skip to content

Commit

Permalink
Revert locales changes and remove i18n from Dockerfile
Browse files Browse the repository at this point in the history
  • Loading branch information
obulat committed Dec 18, 2024
1 parent e939ff5 commit 6ff9026
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/ci_cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ jobs:
setup_python: false
setup_nodejs: ${{ matrix.image == 'frontend' && 'true' || 'false' }}
install_recipe: ${{ matrix.image == 'frontend' && 'node-install' || '' }}
locales: ${{ matrix.image == 'frontend' && 'production' || '' }}

# Sets build args specifying versions needed to build Docker image.
- name: Prepare build args
Expand Down Expand Up @@ -669,6 +670,7 @@ jobs:
with:
setup_python: false
install_recipe: node-install
locales: "production"

- name: Run build
run: just frontend/run build
Expand Down Expand Up @@ -910,6 +912,7 @@ jobs:
with:
setup_python: false
install_recipe: node-install
locales: "test"

- name: Run Playwright tests
run: just frontend/run ${{ matrix.script }} --workers=2
Expand Down
2 changes: 1 addition & 1 deletion frontend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ ENV SKIP_PRE_COMMIT=true
# Get rid of the lockfile as it won't be accurate for the build without workspace.
# Then install dependencies, and in the process:
# - fix the missing lockfile by writing a new one
RUN pnpm install && pnpm i18n
RUN pnpm install

# disable telemetry when building the app
ENV NUXT_TELEMETRY_DISABLED=1
Expand Down

0 comments on commit 6ff9026

Please sign in to comment.