Simplify report views (#1872)

* Simplify report views

* Prevent redundant update statement when creating a report

api/catalog/api/models/media.py

@@ -241,7 +241,10 @@ def save(self, *args, **kwargs):
         )
         if self.status != DEINDEXED:
             same_reports = same_reports.filter(reason=self.reason)
-        same_reports.update(status=self.status)
+
+        # Prevent redundant update statement when creating the report
+        if self.status != PENDING:
+            same_reports.update(status=self.status)
 
 
 class AbstractDeletedMedia(OpenLedgerModel):

api/catalog/api/views/audio_views.py

@@ -93,5 +93,5 @@ def waveform(self, *_, **__):
         methods=["post"],
         serializer_class=AudioReportRequestSerializer,
     )
-    def report(self, *args, **kwargs):
-        return super().report(*args, **kwargs)
+    def report(self, request, identifier):
+        return super().report(request, identifier)

api/catalog/api/views/image_views.py

@@ -179,8 +179,8 @@ def watermark(self, request, *_, **__):
         methods=["post"],
         serializer_class=ImageReportRequestSerializer,
     )
-    def report(self, *args, **kwargs):
-        return super().report(*args, **kwargs)
+    def report(self, request, identifier):
+        return super().report(request, identifier)
 
     # Helper functions
 

api/catalog/api/views/media_views.py

@@ -148,14 +148,11 @@ def related(self, request, identifier=None, *_, **__):
         serializer = self.get_serializer(results, many=True)
         return self.get_paginated_response(serializer.data)
 
-    def report(self, request, *_, **__):
-        media = self.get_object()
-        identifier = media.identifier
+    def report(self, request, identifier):
         serializer = self.get_serializer(data=request.data | {"identifier": identifier})
         serializer.is_valid(raise_exception=True)
-        report = serializer.save()
+        serializer.save()
 
-        serializer = self.get_serializer(report)
         return Response(data=serializer.data, status=status.HTTP_201_CREATED)
 
     def thumbnail(self, image_url, request, *_, **__):