Skip to content

Commit

Permalink
Use a default for HOST_NETWORK_ADDRESS to hide warnings (#3333)
Browse files Browse the repository at this point in the history
  • Loading branch information
dhruvkb authored Nov 10, 2023
1 parent cc9120d commit 37072c9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ services:
ports:
- "50290:8080"
environment:
OPENVERSE_NGINX_UPSTREAM_URL: ${HOST_NETWORK_ADDRESS}:8443
OPENVERSE_NGINX_UPSTREAM_URL: ${HOST_NETWORK_ADDRESS:-172.17.0.1}:8443
OPENVERSE_NGINX_PLAUSIBLE_EVENT_URL: http://plausible:8000/api/event
# Set to Docker network resolver to be able to resolve the `plausible` container.
# This would be the default but Nginx requires it to be explicitly set when
Expand Down
4 changes: 2 additions & 2 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ PROD_ENV := env_var_or_default("PROD_ENV", "")
IS_CI := env_var_or_default("CI", "")
DC_USER := env_var_or_default("DC_USER", "opener")

export HOST_NETWORK_ADDRESS := if os() == "macos" { "host.docker.internal" } else { "172.17.0.1" }

# Show all available recipes, also recurses inside nested justfiles
@_default:
just --list --unsorted
Expand Down Expand Up @@ -128,6 +126,8 @@ export INGESTION_PY_VERSION := `just ingestion_server/py-version`
export FRONTEND_NODE_VERSION := `just frontend/node-version`
export FRONTEND_PNPM_VERSION := `just frontend/pnpm-version`

export HOST_NETWORK_ADDRESS := if os() == "macos" { "host.docker.internal" } else { "172.17.0.1" }

versions:
#!/usr/bin/env bash
cat <<EOF
Expand Down

0 comments on commit 37072c9

Please sign in to comment.