Use format over toJSON for escaping quotes in GHA (#3705)

WordPress · Jan 25, 2024 · 1657abb · 1657abb
1 parent f4901d4
commit 1657abb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml
@@ -13,7 +13,7 @@ jobs:
     env:
       discussion_url: ${{ github.event.discussion.html_url }}
       discussion_number: ${{ github.event.discussion.number }}
-      discussion_title: ${{ toJSON(github.event.discussion.title) }}
+      discussion_title: ${{ format('{0}', github.event.discussion.title) }}
       discussion_author: ${{ github.event.discussion.user.login }}
       discussion_repo: ${{ github.event.repository.full_name }}
       SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

diff --git a/.github/workflows/pr_ping.yml b/.github/workflows/pr_ping.yml
@@ -17,7 +17,7 @@ jobs:
     env:
       pr_url: ${{ github.event.pull_request.html_url }}
       pr_number: ${{ github.event.pull_request.number }}
-      pr_title: ${{ toJSON(github.event.pull_request.title) }}
+      pr_title: ${{ format('{0}', github.event.pull_request.title) }}
       pr_author: ${{ github.event.pull_request.user.login }}
       pr_repo: ${{ github.event.pull_request.base.repo.full_name }}
       SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}