Skip to content

Commit

Permalink
Add changes from code review
Browse files Browse the repository at this point in the history
Signed-off-by: Olga Bulat <[email protected]>
  • Loading branch information
obulat committed Mar 13, 2024
1 parent b58babd commit 1468681
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions frontend/src/components/VCollectionHeader/VCollectionHeader.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div
class="collection-header grid auto-rows-auto gap-2 md:grid-cols-[1fr,auto]"
class="collection-header grid gap-2 md:grid-cols-[1fr,auto]"
:class="{ 'no-link': !showCollectionExternalLink }"
>
<h1 class="title flex flex-col gap-2 md:flex-row">
Expand All @@ -22,7 +22,7 @@
as="VLink"
variant="filled-dark"
size="medium"
class="link label-bold mt-1 !flex-none md:ms-4"
class="link label-bold mt-1 !w-full"
has-icon-end
show-external-icon
:external-icon-size="6"
Expand All @@ -33,7 +33,10 @@
<div
class="results mt-6 flex w-full min-w-0 flex-col items-start gap-1 md:mt-0 md:flex-row md:items-center"
>
<p class="label-regular w-max text-dark-charcoal-70 md:whitespace-nowrap">
<p
class="label-regular w-max text-dark-charcoal-70 md:whitespace-nowrap"
:class="{ 'pb-2 md:pb-0': collection !== 'creator' }"
>
{{ resultsLabel }}
</p>
<VScrollableLine
Expand Down Expand Up @@ -229,7 +232,7 @@ export default defineComponent({
grid-template-areas: "title link" "results results";
}
.no-link {
grid-template-rows: minmax(3.625rem, auto) auto;
grid-template-rows: minmax(3.625rem, auto) minmax(2rem, auto);
grid-template-columns: auto;
grid-template-areas: "title" "results";
}
Expand Down

0 comments on commit 1468681

Please sign in to comment.