Fix inline popover content taking up space

[sarayourfriend]

Fixes

Fixes popover wonkiness on iOS outlined here: #850 (review)

Description

Testing Instructions

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[dhruvkb]

We can directly refer to props by name in the template.

Suggested change

	:tabindex="typeof $props.tabindex !== 'undefined' ? $props.tabindex : -1"
	:tabindex="typeof tabindex !== 'undefined' ? tabindex : -1"

[sarayourfriend]

Looking at this now, it must have meant to have been $attrs instead of $props because there's no tabindex prop... but I cannot figure out why this was necessary. We don't pass tabindex in at VPopover or anywhere else VPopoverContent is used so it seems like dead code to me. VPopover doesn't accept it as a prop that it forwards either so it's not even technically possible for any consumer of VPopover to pass it.

Anyway, set it to constant of -1 in 43d0c29

[dhruvkb]

Non-blocking comment. Looking good otherwise, especially pleased to see one less <style>.

[sarayourfriend]

@dhruvkb I think you'll need to merge this into your branch yourself if you want it 🙂 Or else we'll need a second person to approve this interstitial PR 😛