This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Fix homepage search button and update snapshots #1991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
added
🟧 priority: high
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1991 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
|
Size Change: -5.93 kB (-1%) Total Size: 814 kB
ℹ️ View Unchanged
|
8 tasks
I think this ticket is outdated and refers to a previous version of the homepage redesign. I want to make sure about this before progressing with the development. The homepage's last version is this one and is still in discussion. |
|
@panchovm , this is a quick fix for the previous version of the homepage. There was a regression that we didn't catch in tests, and this PR fixes that. We haven't began working on the new homepage as its design is still under discussion. |
zackkrida
reviewed
Nov 21, 2022
| @@ -24,6 +24,8 @@ for (const dir of languageDirections) { | |||
| test.beforeEach(async ({ page }) => { | |||
| await page.goto(path) | |||
| await dismissTranslationBanner(page) | |||
| // TODO: Remove this after the cookie-based layout is merged. | |||
zackkrida
approved these changes
Nov 21, 2022
obulat
force-pushed
the
update/homepage_snapshots
branch
from
dc69531 to
b6b749e
Compare
obulat
added a commit
that referenced
this pull request
Nov 22, 2022
|
Playwright Failure Test Results It looks like some of the Playwright tests failed. You can download the Playwright trace https://github.com/WordPress/openverse-frontend/actions/runs/3525164584 Read more about how to use this artifact here: https://github.com/WordPress/openverse-frontend/blob/main/test/playwright/README.md#debugging |
|
I moved the changes from here to #1992 to simplify merging and fixing PW tests faster. |
obulat
added a commit
that referenced
this pull request
Nov 23, 2022
* Make the visual regression tests stricter * Add changes from Fix homepage search button and update snapshots #1991 * Revert rtl-flip on the search icon; update the single result pages (header height)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #1979 by @obulat
Description
The homepage search bar's button on screens larger than
mdwas using an icon, although it should be using a text label.This PR edits the computed to fix this issue. It also simplifies the Search Button, removing redundant
$attrs-related properties.Testing Instructions
The Search form should correctly submit if you click (or press Enter) on the search button on the homepage, the 404 page and the search page. The snapshots should match the mockups.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin